[PATCH 01/10] base-files: upgrade: log with prefix

[Adrian Schmutzler]

Hi,

> -----Original Message-----
> From: Yousong Zhou [mailto:yszhou4tech at gmail.com]
> Sent: Dienstag, 3. November 2020 16:05
> To: Adrian Schmutzler <mail at adrianschmutzler.de>
> Cc: Philip Prindeville <philipp at redfish-solutions.com>; OpenWrt
> Development List <openwrt-devel at lists.openwrt.org>
> Subject: Re: [PATCH 01/10] base-files: upgrade: log with prefix
> 
> On Tue, 3 Nov 2020 at 21:02, Adrian Schmutzler <mail at adrianschmutzler.de>
> wrote:
> >
> > Hi,
> >
> > > -----Original Message-----
> > > From: openwrt-devel [mailto:openwrt-devel-
> bounces at lists.openwrt.org]
> > > On Behalf Of Yousong Zhou
> > > Sent: Dienstag, 3. November 2020 13:21
> > > To: Philip Prindeville <philipp at redfish-solutions.com>
> > > Cc: Yousong Zhou <yszhou4tech at gmail.com>; openwrt-
> > > devel at lists.openwrt.org
> > > Subject: [PATCH 01/10] base-files: upgrade: log with prefix
> > >
> > > Signed-off-by: Yousong Zhou <yszhou4tech at gmail.com>
> > > ---
> > >  package/base-files/files/lib/upgrade/common.sh | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/package/base-files/files/lib/upgrade/common.sh
> > > b/package/base-files/files/lib/upgrade/common.sh
> > > index 2eb26ba44b..56daabd778 100644
> > > --- a/package/base-files/files/lib/upgrade/common.sh
> > > +++ b/package/base-files/files/lib/upgrade/common.sh
> > > @@ -64,7 +64,7 @@ ask_bool() {
> > >  }
> > >
> > >  v() {
> >
> > Generally, I like the idea. I'm not sure whether just v() is a good choice for
> the function name, though.
> >
> > > -     [ -n "$VERBOSE" ] && [ "$VERBOSE" -ge 1 ] && echo "$@"
> > > +     [ -n "$VERBOSE" ] && [ "$VERBOSE" -ge 1 ] && echo "== upgrade:
> > > $@"
> >
> > Is there a particular reason for choosing "==" as prefix or is this arbitrary?
> Looks a bit odd to me (not the fact of having a prefix, but the prefix itself) ...
> 
> I should have mentioned this in the cover letter ;)
> 
> "==" is there mainly to make the lines stand out by looking a bit different.  I
> tried other characters like "--", "##" etc.  "==" seems the best.  "$(date)" was
> also tried for once but it's not available at later stages of sysupgrade.  Maybe
> I should try again and use datetime as the prefix.

I don't want to make it more complicated than necessary.
The date might separate the lines from the others as well, but I'm not sure whether that would really make it easier to read eventually ...

Best

Adrian

> 
> Regards,
>                 yousong
> 
> >
> > In any case, thanks for the improvements.
> >
> > Best
> >
> > Adrian
> >
> > >  }
> > >
> > >  json_string() {
> > >
> > > _______________________________________________
> > > openwrt-devel mailing list
> > > openwrt-devel at lists.openwrt.org
> > > https://lists.openwrt.org/mailman/listinfo/openwrt-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: openpgp-digital-signature.asc
Type: application/pgp-signature
Size: 834 bytes
Desc: not available
URL: <http://lists.openwrt.org/pipermail/openwrt-devel/attachments/20201103/479aa401/attachment-0001.sig>