[PATCH 01/10] base-files: upgrade: log with prefix

[Adrian Schmutzler]

Hi,

> -----Original Message-----
> From: openwrt-devel [mailto:openwrt-devel-bounces at lists.openwrt.org]
> On Behalf Of Yousong Zhou
> Sent: Dienstag, 3. November 2020 13:21
> To: Philip Prindeville <philipp at redfish-solutions.com>
> Cc: Yousong Zhou <yszhou4tech at gmail.com>; openwrt-
> devel at lists.openwrt.org
> Subject: [PATCH 01/10] base-files: upgrade: log with prefix
> 
> Signed-off-by: Yousong Zhou <yszhou4tech at gmail.com>
> ---
>  package/base-files/files/lib/upgrade/common.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/package/base-files/files/lib/upgrade/common.sh
> b/package/base-files/files/lib/upgrade/common.sh
> index 2eb26ba44b..56daabd778 100644
> --- a/package/base-files/files/lib/upgrade/common.sh
> +++ b/package/base-files/files/lib/upgrade/common.sh
> @@ -64,7 +64,7 @@ ask_bool() {
>  }
> 
>  v() {

Generally, I like the idea. I'm not sure whether just v() is a good choice for the function name, though.

> -	[ -n "$VERBOSE" ] && [ "$VERBOSE" -ge 1 ] && echo "$@"
> +	[ -n "$VERBOSE" ] && [ "$VERBOSE" -ge 1 ] && echo "== upgrade:
> $@"

Is there a particular reason for choosing "==" as prefix or is this arbitrary? Looks a bit odd to me (not the fact of having a prefix, but the prefix itself) ...

In any case, thanks for the improvements.

Best

Adrian

>  }
> 
>  json_string() {
> 
> _______________________________________________
> openwrt-devel mailing list
> openwrt-devel at lists.openwrt.org
> https://lists.openwrt.org/mailman/listinfo/openwrt-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: openpgp-digital-signature.asc
Type: application/pgp-signature
Size: 834 bytes
Desc: not available
URL: <http://lists.openwrt.org/pipermail/openwrt-devel/attachments/20201103/9b822679/attachment.sig>