[OpenWrt-Devel] [PATCH] build: reflect DEVICE_TYPE to top level config

[Linus Walleij]

On Fri, May 29, 2020 at 7:39 PM <mail at adrianschmutzler.de> wrote:

> sorry for intruding into this subject, but this has annoyed me for a long time already.

I am very happy that you are taking up the subject :D

> I've just sent a small patchset to tidy up the existing situation.

Excellent, will look.

> As you stated earlier, it's just not so easy to connect the target and device scopes with each other. At the moment, I see two ways out of this:
>
> 1. We just live with the fact that the switch between router/nas/basic is per subtarget and adjust the code based on that.
> 2. We make the DEVICE_TYPE a real device-dependent variable and move it from target.mk to image.mk. Then, we could still set default values per target, but would have to adjust DEVICE_PACKAGES instead of DEFAULT_PACKAGES, which would lead to problems when building the Default Profile, but would make it much easier to deal with the individual devices.

I vote for (2)

> Anyway, thanks for stirring this topic up again. Unfortunately, I don't think this will come cheap.

Yeah I started looking at it and it was "mildly confusing" but as I
anyway had to
learn how OpenWrt is generating the Kconfig menus from Makefiles using
a perl script it was a minor thing compared to figuring out the overall picture.
I knew I would get it wrong anyways. ;)

Yours,
Linus Walleij

_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel