[OpenWrt-Devel] [PATCH 3/3] treewide: rename DEVICE_TYPE to DEFAULT_TYPE

[Matthias Schiffer]

On 5/30/20 1:04 AM, mail at adrianschmutzler.de wrote:
>> The variable is used rarely enough that we could well make this a bit more 
>> verbose. "TARGET_DEVICE_TYPE"? If it weren't for the busybox config change 
>> (which seems hacky to me at best*), we could also go with something like 
>> TARGET_PACKAGEGROUP, as the package selection would be the only thing 
>> controlled by this variable... 
> 
> Maybe just DEFAULT_PACKAGES_TYPE?
> 

Hmm, at a glance, I still find this very ambiguous. Rather than "the type
(of what?) for the default packages", someone who doesn't know the build
system might interpret it as "the default type of the packages" (What would
that even mean? RPM vs. DEB vs. OPKG like OE supports?)

Matthias

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/openwrt-devel/attachments/20200530/1cb967ca/attachment.sig>
-------------- next part --------------
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel