[OpenWrt-Devel] [PATCH v7] ramips: add support for TRENDnet TEW-810DR
mail at adrianschmutzler.de
mail at adrianschmutzler.de
Tue May 26 05:31:50 EDT 2020
> -----Original Message-----
> From: openwrt-devel [mailto:openwrt-devel-bounces at lists.openwrt.org]
> On Behalf Of Heppler, J. Scott
> Sent: Dienstag, 26. Mai 2020 03:25
> To: openwrt-devel at openwrt.org
> Subject: [OpenWrt-Devel] [PATCH v7] ramips: add support for TRENDnet
> TEW-810DR
>
> * MediaTek MT7620A (580 Mhz)
> * 8 MB of FLASH * 64 MB of RAM
> * 2.4Ghz and 5.0Ghz radios both now functional
Drop the "both now functional"
> * 5x 10/100 Mbps Ethernet (1 WAN and 4 LAN)
> * UART header on PCB (57600 8n1)
> * Green/Orange Power LEDs illuminating a Power-Button Lens
> Green/Orange Internet LEDs GPIO controlled illuminating a Globe/Internet
> Lens
> * 3x button - wps, power and reset
> * U-boot bootloader
I'd still like to know whether there are valid MAC addresses in other flash locations, i.e. 0x4, 0x8004, 0x2e. The WiFi MAC addresses should only be set up from a separate address if absolutely necessary, and I'm not convinced that's necessary yet.
I haven't found any information about that on a quick look into my mail history, and the fact that you just ignored it for your newer patches also doesn't help.
Please provide that information, and if possible also the MAC address assignment (lan,wan,2g,5g) on vendor OS and on a device label. If it's easier for you, you may also just send me a dump of the factory partition to my private address.
Despite, while you have dropped lan LED now and added a wan LED, you still rely on ucidef_set_led_netdev instead of ucidef_set_led_switch. Please use the latter if you deal with ports on a switch.
You can also drop the "link tx rx" as this is default. Please support both LEDs, not just lan _or_ wan.
Finally, please note that I don't care about whether this matches any other device's definition. It should be correct for the device at hand, and if the other device deviates, then please either fix that one as well or just ignore it. But making support worse just for consistency with an old support isn't desirable IMO.
Best
Adrian
>
> Installation:
>
> The sysupgrade.bin image is reported to be OEM web flashed with an
> ncc_att_hwid appended. ncc_att_hwid is a 32bit binary in the GPL Source
> download for either the TEW-810DR or DIR-810L and is located at
> source/user/wolf/cameo/ncc/hostTools.
> The invocation is: ncc_att_hwid
> -f tew-810dr-squashfs-factory.bin -a -m "TEW-810DR" -H "1.0R" -r "WW" -c
> "1.0"
> This may need to be altered if your hardware version is "1.1R".
> The image can also be directly flashed via serial tftp.
> 1. Load *.sysupgrade.bin to your tftp server directory and rename for
> convenience.
> 2. Set a static ip 192.168.10.100.
> 3. NIC cable to a lan port.
> 4. Serial connection parameters 57600,8N1 5. Power on the TEW-810 and
> press 4 for a u-boot command line prompt.
> 6. Verify IP's with U-Boot command "printenv".
> 7. Adjust tftp settings if needed per the tftp documentation 8. Boot the tftp
> image to test the build.
> 9. If the image loads, reset your server ip to 192.168.1.10 and restart
> network.
> 10. Log in to Luci, 192.168.1.1, and flash the *sysupgrade.bin image.
>
> Summary v4 -> v5 -> v6
> 1. Enumerated installation steps and corrected grammar.
> 2. Added SPDX License Identifier to *.dts.
> 3. gpio-keys-polled -> gpio-keys in *.dts.
> 4. gpio2 0 is actually behind a Globe/Internet lens - changed to wan.
> 5. Increased spi-max-frequency 10000000 -> 50000000 6. jffs2 partition
> 0xe0000 -> 0xf0000.
> 7. &state_default groups dropped mdio, rgmii1, wled.
> 8. MAC assignments mirror DIR-810L and verify in Luci. Unchanged
> 02_network and *.dts.
> 9. 01_leds changed consistent with #4.
> 10. Removed SUPPORTED_DEVICES from image/mt7620.mk. Note: the D-
> Link DIR-810L has the same SUPPORTED_DEVICES entry in image/mt7620.mk.
> 11. Builds/Runs on my test Device.
>
> Summary v6 -> v7
> 1. White space issues in &wmac *.dts, image/mt7620.mk, 01_leds and
> 02_network;
> spaces replaced with tabs
>
> Signed-off-by: J. Scott Heppler <shep971 at centurylink.net>
> ---
> .../ramips/dts/mt7620a_trendnet_tew-810dr.dts | 166
> ++++++++++++++++++
> target/linux/ramips/image/mt7620.mk | 9 +
> .../mt7620/base-files/etc/board.d/01_leds | 3 +
> .../mt7620/base-files/etc/board.d/02_network | 4 +-
> 4 files changed, 181 insertions(+), 1 deletion(-)
> create mode 100644 target/linux/ramips/dts/mt7620a_trendnet_tew-
> 810dr.dts
>
> diff --git a/target/linux/ramips/dts/mt7620a_trendnet_tew-810dr.dts
> b/target/linux/ramips/dts/mt7620a_trendnet_tew-810dr.dts
> new file mode 100644
> index 0000000000..2873b5d780
> --- /dev/null
> +++ b/target/linux/ramips/dts/mt7620a_trendnet_tew-810dr.dts
> @@ -0,0 +1,166 @@
> +//SPDX-License-Identifier: GPL-2.0-or-later OR MIT /dts-v1/;
> +
> +#include "mt7620a.dtsi"
> +
> +#include <dt-bindings/gpio/gpio.h>
> +#include <dt-bindings/input/input.h>
> +
> +/ {
> + compatible = "trendnet,tew-810dr", "ralink,mt7620a-soc";
> + model = "TRENDnet TEW-810DR";
> +
> + aliases {
> + led-boot = &led_power_green;
> + led-failsafe = &led_power_green;
> + led-running = &led_power_green;
> + led-upgrade = &led_power_green;
> + label-mac-device = ðernet;
> + };
> +
> + keys {
> + compatible = "gpio-keys";
> +
> + reset {
> + label = "reset";
> + gpios = <&gpio0 1 GPIO_ACTIVE_LOW>;
> + linux,code = <KEY_RESTART>;
> + };
> +
> + wps {
> + label = "wps";
> + gpios = <&gpio0 2 GPIO_ACTIVE_LOW>;
> + linux,code = <KEY_WPS_BUTTON>;
> + };
> + };
> +
> + leds {
> + compatible = "gpio-leds";
> +
> + led_power_green: power_green {
> + label = "tew-810dr:green:power";
> + gpios = <&gpio0 9 GPIO_ACTIVE_HIGH>;
> + };
> +
> + wan_orange: wan_orange {
> + label = "tew-810dr:orange:wan";
> + gpios = <&gpio0 12 GPIO_ACTIVE_HIGH>;
> + };
> +
> + wan_green: wan_green {
> + label = "tew-810dr:green:wan";
> + gpios = <&gpio2 0 GPIO_ACTIVE_LOW>;
> + };
> +
> + led_power_orange {
> + label = "tew-810dr:orange:power";
> + gpios = <&gpio0 13 GPIO_ACTIVE_HIGH>;
> + };
> + };
> +};
> +
> +&spi0 {
> + status = "okay";
> +
> + flash at 0 {
> + compatible = "jedec,spi-nor";
> + reg = <0>;
> + spi-max-frequency = <50000000>;
> +
> + partitions {
> + compatible = "fixed-partitions";
> + #address-cells = <1>;
> + #size-cells = <1>;
> +
> + partition at 0 {
> + label = "u-boot";
> + reg = <0x0 0x30000>;
> + read-only;
> + };
> +
> + partition at 30000 {
> + label = "u-boot-env";
> + reg = <0x30000 0x10000>;
> + read-only;
> + };
> +
> + factory: partition at 40000 {
> + label = "factory";
> + reg = <0x40000 0x10000>;
> + read-only;
> + };
> +
> + factory5g: partition at 50000 {
> + label = "factory5g";
> + reg = <0x50000 0x10000>;
> + read-only;
> + };
> +
> + partition at 60000 {
> + label = "Wolf_Config";
> + reg = <0x60000 0x10000>;
> + read-only;
> + };
> +
> + partition at 70000 {
> + label = "MyDlink";
> + reg = <0x70000 0x80000>;
> + read-only;
> + };
> +
> + partition at f0000 {
> + label = "Jffs2";
> + reg = <0xf0000 0x80000>;
> + read-only;
> + };
> +
> + partition at 170000 {
> + compatible = "denx,uimage";
> + label = "firmware";
> + reg = <0x170000 0x690000>;
> + };
> + };
> + };
> +};
> +
> +&state_default {
> + gpio {
> + groups = "i2c", "uartf", "ephy";
> + function = "gpio";
> + };
> +};
> +
> +ðernet {
> + mtd-mac-address = <&factory 0x28>;
> + mediatek,portmap = "llllw";
> +};
> +
> +&gsw {
> + mediatek,port4 = "ephy";
> +};
> +
> +&pcie {
> + status = "okay";
> +};
> +
> +&wmac {
> + pinctrl-names = "default";
> + pinctrl-0 = <&pa_pins>;
> +
> + ralink,mtd-eeprom = <&factory 0x0>;
> + mtd-mac-address = <&factory 0x28>;
> +};
> +
> +&pcie0 {
> + wifi at 0,0 {
> + reg = <0x0000 0 0 0 0>;
> + mediatek,mtd-eeprom = <&factory 0x8000>;
> + ieee80211-freq-limit = <5000000 6000000>;
> + mtd-mac-address = <&factory 0x28>;
> + mtd-mac-address-increment = <2>;
> + };
> +};
> +
> +&gpio2 {
> + status = "okay";
> +};
> diff --git a/target/linux/ramips/image/mt7620.mk
> b/target/linux/ramips/image/mt7620.mk
> index e435b1d15f..386809e40f 100644
> --- a/target/linux/ramips/image/mt7620.mk
> +++ b/target/linux/ramips/image/mt7620.mk
> @@ -1005,6 +1005,15 @@ define Device/tplink_re210-v1
> endef
> TARGET_DEVICES += tplink_re210-v1
>
> +define Device/trendnet_tew-810dr
> + SOC := mt7620a
> + DEVICE_PACKAGES := kmod-mt76x0e
> + DEVICE_VENDOR := TRENDnet
> + DEVICE_MODEL := TEW-810DR
> + IMAGE_SIZE := 6720k
> +endef
> +TARGET_DEVICES += trendnet_tew-810dr
> +
> define Device/vonets_var11n-300
> SOC := mt7620n
> IMAGE_SIZE := 3776k
> diff --git a/target/linux/ramips/mt7620/base-files/etc/board.d/01_leds
> b/target/linux/ramips/mt7620/base-files/etc/board.d/01_leds
> index c1deae59e3..595f84f5d2 100755
> --- a/target/linux/ramips/mt7620/base-files/etc/board.d/01_leds
> +++ b/target/linux/ramips/mt7620/base-files/etc/board.d/01_leds
> @@ -191,6 +191,9 @@ tplink,archer-mr200)
> tplink,re200-v1)
> ucidef_set_led_netdev "lan" "lan" "$boardname:green:lan" "eth0"
> ;;
> +trendnet,tew-810dr)
> + ucidef_set_led_netdev "wan" "wan" "$boardname:green:wan"
> "eth0.2" "link tx rx"
> + ;;
> youku,yk1)
> set_wifi_led "$boardname:blue:air"
> ucidef_set_led_switch "wan" "wan" "$boardname:blue:wan"
> "switch0" "0x10"
> diff --git a/target/linux/ramips/mt7620/base-files/etc/board.d/02_network
> b/target/linux/ramips/mt7620/base-files/etc/board.d/02_network
> index d024674c10..2a54fa12e9 100755
> --- a/target/linux/ramips/mt7620/base-files/etc/board.d/02_network
> +++ b/target/linux/ramips/mt7620/base-files/etc/board.d/02_network
> @@ -26,6 +26,7 @@ ramips_setup_interfaces()
> ralink,mt7620a-mt7610e-evb|\
> ralink,mt7620a-v22sg-evb|\
> sanlinking,d240|\
> + trendnet,tew-810dr|\
> youku,yk1|\
> zbtlink,zbt-ape522ii|\
> zbtlink,zbt-we826-16m|\
> @@ -259,7 +260,8 @@ ramips_setup_macs()
> alfa-network,ac1200rm|\
> dlink,dir-810l|\
> phicomm,psg1218a|\
> - phicomm,psg1218b)
> + phicomm,psg1218b|\
> + trendnet,tew-810dr)
> wan_mac=$(macaddr_add "$(mtd_get_mac_binary factory
> 0x28)" 1)
> ;;
> alfa-network,r36m-e4g|\
> --
> 2.20.1
>
>
>
>
> --
> J. Scott Heppler
>
> _______________________________________________
> openwrt-devel mailing list
> openwrt-devel at lists.openwrt.org
> https://lists.openwrt.org/mailman/listinfo/openwrt-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: openpgp-digital-signature.asc
Type: application/pgp-signature
Size: 834 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/openwrt-devel/attachments/20200526/ea7bd39e/attachment.sig>
-------------- next part --------------
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel
More information about the openwrt-devel
mailing list