[OpenWrt-Devel] [PATCH] netifd: fix compilation with musl 1.2.0
Paul Oranje
por at oranjevos.nl
Wed Mar 25 04:58:12 EDT 2020
Hi Rosen e.a.
> Op 25 mrt. 2020, om 09:27 heeft Petr Štetiar <ynezz at true.cz> het volgende geschreven:
>
> Rosen Penev <rosenp at gmail.com> [2020-03-24 22:56:19]:
>
> Hi,
>
>> --- a/system-linux.c
>> +++ b/system-linux.c
>> @@ -59,6 +59,10 @@
>> #define IFA_FLAGS (IFA_MULTICAST + 1)
>> #endif
>>
>> +#ifndef __NR_clock_gettime
>> +#define __NR_clock_gettime __NR_clock_gettime64
>> +#endif
>
> could you fix it by removing that probably now obsolete workaround by
> replacing that syscall() with direct clock_gettime()? Thanks!
>
In general, how applaudable the effort, for the whole series of fixes having to do with handling changes that tackle 2038, it would be preferable to have those grouped together (under one cover letter ?) and consisting of fixing the call sites i.s.o. the quick fixes with defines.
Regards
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel
More information about the openwrt-devel
mailing list