[OpenWrt-Devel] [RFC PATCH] ath9k: enable hardware random number generator.

[Rui Salvaterra]

Hi again, Petr.

A domingo, 1/03/2020, 13:47, Petr Štetiar <ynezz at true.cz> escreveu:

> Rui Salvaterra <rsalvaterra at gmail.com> [2020-03-01 13:39:37]:
>
> > Ah, silly me, you're absolutely right. This is just half the patch, and
> > it's perfectly fine the way it is, so I'm not enabling anything new, just
> > exposing the existing kconfig. Please ignore my previous email.
>
> Well, I've re-read it again.
>
> Your commit description forget to mention, that you're actually removing
> ADC
> based RNG feeding for ar5k, which is missing in that upstream rng.c.
>

Yes, I don't want to regress that, of course.

So commit subject and commit description needs some work. You should
> consider
> as well Felix's remark and if I were your, I would simply handle this via
> upstream, once upstreamed, simply backported it to OpenWrt.
>

That's my preferred course of action too, upstream first. As for Felix's
concerns, I'm very thoroughly testing on all the hardware I can get my
hands on. I'm worried the most about AR5008, which is the earliest one, but
now I have a card to test it.

Thanks,
Rui
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.infradead.org/pipermail/openwrt-devel/attachments/20200301/62fa4d85/attachment.htm>
-------------- next part --------------
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel