[PATCH v2 1/2] vxlan: remove mandatory peeraddr

[mail at adrianschmutzler.de]

> -----Original Message-----
> From: openwrt-devel [mailto:openwrt-devel-bounces at lists.openwrt.org]
> On Behalf Of Johannes Kimmel
> Sent: Montag, 20. Juli 2020 08:05
> To: openwrt-devel at lists.openwrt.org
> Cc: Johannes Kimmel <fff at bareminimum.eu>; mschiffer at universe-
> factory.net
> Subject: [PATCH v2 1/2] vxlan: remove mandatory peeraddr
> 
> vxlan can be configured without a peer address. This is used to prepare an
> interface and add peers later.
> 
> Fixes: FS#2743
> 
> Signed-off-by: Johannes Kimmel <fff at bareminimum.eu>

You already received an

Acked-by: Matthias Schiffer <mschiffer at universe-factory.net>

on this one for the v1, which is the same as this one except for the Fixes: line added.

This kind of feedback is valuable, so you should keep/add it for newer versions (if there are any; for patchwork, the Acked-by should be picked up as I posted it here).

Best

Adrian

> ---
>  package/network/config/vxlan/files/vxlan.sh | 12 ------------
>  1 file changed, 12 deletions(-)
> 
> diff --git a/package/network/config/vxlan/files/vxlan.sh
> b/package/network/config/vxlan/files/vxlan.sh
> index 7b1c703..bdcaa62 100755
> --- a/package/network/config/vxlan/files/vxlan.sh
> +++ b/package/network/config/vxlan/files/vxlan.sh
> @@ -55,12 +55,6 @@ proto_vxlan_setup() {
>  	local ipaddr peeraddr
>  	json_get_vars ipaddr peeraddr tunlink
> 
> -	[ -z "$peeraddr" ] && {
> -		proto_notify_error "$cfg" "MISSING_ADDRESS"
> -		proto_block_restart "$cfg"
> -		exit
> -	}
> -
>  	( proto_add_host_dependency "$cfg" '' "$tunlink" )
> 
>  	[ -z "$ipaddr" ] && {
> @@ -85,12 +79,6 @@ proto_vxlan6_setup() {
>  	local ip6addr peer6addr
>  	json_get_vars ip6addr peer6addr tunlink
> 
> -	[ -z "$peer6addr" ] && {
> -		proto_notify_error "$cfg" "MISSING_ADDRESS"
> -		proto_block_restart "$cfg"
> -		exit
> -	}
> -
>  	( proto_add_host_dependency "$cfg" '' "$tunlink" )
> 
>  	[ -z "$ip6addr" ] && {
> --
> 2.27.0
> 
> 
> _______________________________________________
> openwrt-devel mailing list
> openwrt-devel at lists.openwrt.org
> https://lists.openwrt.org/mailman/listinfo/openwrt-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: openpgp-digital-signature.asc
Type: application/pgp-signature
Size: 834 bytes
Desc: not available
URL: <http://lists.openwrt.org/pipermail/openwrt-devel/attachments/20200720/2d07ac05/attachment-0001.sig>