[RFC PATCH 5/7] ath79: support for TP-Link EAP245 v1

[Sander Vanheule]

Hi Adrian,

On Fri, 2020-07-17 at 14:54 +0200, mail at adrianschmutzler.de wrote:
> Hi,
> 
> > diff --git a/target/linux/ath79/dts/qca9563_tplink_eap245-v1.dts
> > b/target/linux/ath79/dts/qca9563_tplink_eap245-v1.dts
> > new file mode 100644
> > index 0000000000..8a11d2e469
> > --- /dev/null
> > +++ b/target/linux/ath79/dts/qca9563_tplink_eap245-v1.dts
> > @@ -0,0 +1,26 @@
> > +// SPDX-License-Identifier: GPL-2.0-or-later OR MIT /dts-v1/;
> > +
> > +#include <dt-bindings/gpio/gpio.h>
> 
> This line is already in the DTSI.

Fixed.

> > +
> > +#include "qca9563_tplink_eap2x5_1port.dtsi"
> > +
> > +/ {
> > +	compatible = "tplink,eap245-v1", "qca,qca9563";
> > +	model = "TP-Link EAP245 v1";
> > +};
> > +
> > +&led_status_green {
> > +	status = "okay";
> > +	gpios = <&gpio 7 GPIO_ACTIVE_HIGH>;
> > +};
> > +
> > +&led_status_amber {
> > +	status = "okay";
> > +	gpios = <&gpio 9 GPIO_ACTIVE_HIGH>;
> > +};
> > +
> > +&led_status_red {
> > +	status = "okay";
> > +	gpios = <&gpio 1 GPIO_ACTIVE_HIGH>;
> > +};
> 
> Use the whole LED block in the root node here, see my comment on the
> DTSI ...

Done. The root node now contains the leds block, as well as the led-*
aliases.

> > diff --git a/target/linux/ath79/generic/base-
> > files/etc/hotplug.d/firmware/11-
> > ath10k-caldata b/target/linux/ath79/generic/base-
> > files/etc/hotplug.d/firmware/11-ath10k-caldata
> > index 2926796d65..d722f2dcaf 100644
> > --- a/target/linux/ath79/generic/base-
> > files/etc/hotplug.d/firmware/11-
> > ath10k-caldata
> > +++ b/target/linux/ath79/generic/base-
> > files/etc/hotplug.d/firmware/11-at
> > +++ h10k-caldata
> > @@ -63,7 +63,8 @@ case "$FIRMWARE" in
> >  		caldata_extract "art" 0x5000 0x844
> >  		ath10k_patch_mac $(macaddr_add $(mtd_get_mac_ascii u-
> > boot-env ethaddr) +1)
> >  		;;
> > -	engenius,ews511ap)
> > +	engenius,ews511ap|\
> > +	tplink,eap245-v1)
> >  		caldata_extract "art" 0x5000 0x844
> >  		ath10k_patch_mac $(macaddr_add $(cat
> > /sys/class/net/eth0/address) +1)
> 
> Please don't define this relative to eth0, but use the flash
> locations as a base, e.g.
> 
> ath10k_patch_mac $(macaddr_add $(mtd_get_mac_binary info 0x8) +1)
> 

Fixed. This is now identical to the line for the two other devices.


Best,
Sander