[OpenWrt-Devel] [PATCH 0/5] Add 802.11ad support

Daniel Golle daniel at makrotopia.org
Thu Jan 16 04:04:04 EST 2020


Hi Nick,

On Thu, Jan 16, 2020 at 09:08:01AM +0100, Nick wrote:
> Why are this patches not merged upstream?

Probably because nobody suitable hardware at hand could review and test
the patches. Probably it'd be better to first add the basic device
bring-up and then add 11ad support.

> You always have to rebase and solve merge conflicts if you work on 60
> GHz. :/

I'd also love to see this getting merged!

> 
> I would really appreciate it if this is merged. And if there is a reason
> why this stuff is not getting upstream, I volunteer to work on it.

Please resend the patches rebased on master and add your Tested-by:
tag and I will merge them.
Imho review doesn't need to be done by core developers, but without
any public review/testing nobody will dare to blindly merge.
Maybe we should establish more of a culture to encourage also people
without commit rights to reply to patches adding Acked-by and Tested-by
tags...


Cheers


Daniel



> 
> Best,
> Nick
> 
> On 08.11.19 19:14, Adrian Schmutzler wrote:
> > Cc: Robert Marko <robimarko at gmail.com>
> >
> > This is a pick of commits from device support PR #2417:
> > https://github.com/openwrt/openwrt/pull/2417
> >
> > There has been a request to merge those particular commits,
> > as they are required for any 60 GHz capable device, so
> > merging them will obviously make things easier for other
> > developers.
> >
> > The credit for writing them goes to robimarko, I'm just
> > bringing them to the list to speed things up a little.
> >
> > I'd be happy to receive comments, Acked-by or Reviewed-by
> > feedback, as I cannot properly review them on my own.
> >
> > Robert Marko (5):
> >   linux-firmware: add wil6210 firmware
> >   mac80211: add wil6210 driver
> >   mac80211: add 802.11ad support
> >   base-files: wifi: add 802.11ad support
> >   hostapd: wpa_supplicant: enable proper GCMP cipher support
> >
> >  package/base-files/files/sbin/wifi             |  1 +
> >  package/firmware/linux-firmware/qca.mk         |  8 ++++++++
> >  package/kernel/mac80211/ath.mk                 | 18 +++++++++++++++---
> >  .../kernel/mac80211/files/lib/wifi/mac80211.sh | 18 +++++++++++-------
> >  .../network/services/hostapd/files/hostapd.sh  |  7 +++++++
> >  5 files changed, 42 insertions(+), 10 deletions(-)
> >
> 
> _______________________________________________
> openwrt-devel mailing list
> openwrt-devel at lists.openwrt.org
> https://lists.openwrt.org/mailman/listinfo/openwrt-devel

_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel



More information about the openwrt-devel mailing list