[OpenWrt-Devel] [PATCHv2 1/2] scripts/gen_image_generic.sh: Replace -o with ||

[mail at adrianschmutzler.de]

Hi,

> -[ $# == 5 -o $# == 6 ] || {
> +if [ $# -ne 5 ] || [ $# -ne 6 ]; then

I think it should be

if [ $# -ne 5 ] && [ $# -ne 6 ]; then

If you resend, please make the commit title lower-case (thanks for already doing that for most of the other newer patches).

Best

Adrian 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: openpgp-digital-signature.asc
Type: application/pgp-signature
Size: 834 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/openwrt-devel/attachments/20200103/8c96af02/attachment.sig>
-------------- next part --------------
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel