[OpenWrt-Devel] [PATCH] kirkwood: convert DTS patches into plain DTS files

[Adrian Schmutzler]

> -----Original Message-----
> From: Raylynn Knight [mailto:rayknight at me.com]
> Sent: Donnerstag, 27. Februar 2020 06:16
> To: Adrian Schmutzler <mail at adrianschmutzler.de>
> Cc: openWrt Development List <openwrt-devel at lists.openwrt.org>
> Subject: Re: [OpenWrt-Devel] [PATCH] kirkwood: convert DTS patches into plain
> DTS files
> 
> Sorry, I did intend the email for the list.
> 
> I actually have an example of all of the devices affected by this patch except
the
> nsa310b.  Would there be any issue with me trying to get the OpenWrt patches
> upstreamed?

You are welcome. I'd consider trying to contact the initial authors of the
patches beforehand for they maybe can provide help or additional insights.

I will merge this patch soon anyway, and will do a quick (partial) cosmetic
fixup on top as well. Maybe you wait for this so we get the "nicer" version into
kernel?

Best

Adrian

> 
> Ray
> 
> 
> > On Feb 25, 2020, at 5:55 AM, Adrian Schmutzler <mail at adrianschmutzler.de>
> wrote:
> >
> > Hi Ray,
> >
> > was this a private message by intention?
> >
> > This patch only reorganizes the existing files in OpenWrt's kirkwood. While
I've
> > been involved in cleaning up the kirkwood target recently, this not even my
> > patch.
> >
> > I personally don't think that upstreaming DTS files for devices I've never
even
> > touched is a good idea. For that, I think the best way would be to contact
the
> > original authors of device support or at least find somebody who really has
the
> > device.
> >
> > So, while I would welcome to upstream the code in general, I do not see that
> > this would be Sungbo Eo's or my job right now.
> >
> > In contrast, it might be a good idea to mention this in the currently
pending
> > device support PRs for Kirkwood if you think it would be worth it.
> >
> > Best
> >
> > Adrian
> >
> >> -----Original Message-----
> >> From: Raylynn Knight [mailto:rayknight at me.com]
> >> Sent: Dienstag, 25. Februar 2020 04:39
> >> To: Adrian Schmutzler <mail at adrianschmutzler.de>
> >> Subject: Re: [OpenWrt-Devel] [PATCH] kirkwood: convert DTS patches into
> plain
> >> DTS files
> >>
> >> What is the reason that these DTS files are not submitted upstream to the
> >> kernel?
> >>
> >> Ray
> >>
> >>
> >>> On Feb 24, 2020, at 8:23 AM, Adrian Schmutzler <mail at adrianschmutzler.de>
> >> wrote:
> >>>
> >>> Hi,
> >>>
> >>>> -----Original Message-----
> >>>> From: openwrt-devel [mailto:openwrt-devel-bounces at lists.openwrt.org]
> On
> >>>> Behalf Of Sungbo Eo
> >>>> Sent: Montag, 24. Februar 2020 13:06
> >>>> To: openwrt-devel at lists.openwrt.org
> >>>> Cc: Sungbo Eo <mans0n at gorani.run>
> >>>> Subject: [OpenWrt-Devel] [PATCH] kirkwood: convert DTS patches into
> plain
> >> DTS
> >>>> files
> >>>>
> >>>> Move DTS files newly created by patch files to files directory. This will
> > make
> >>>> these files much more maintainable.
> >>>>
> >>>> Patching the kernel Makefile is unnecessary, as the DTS files specified
in
> >>>> DEVICE_DTS will be compiled by OpenWrt buildroot anyway.
> >>>
> >>> I personally see it the same way, though I'm aware this in handled
> > differently
> >>> for different targets.
> >>> This change will just remove one layer of complexity.
> >>>
> >>> Acked-by: Adrian Schmutzler <freifunk at adrianschmutzler.de>
> >>>
> >>> Best
> >>>
> >>> Adrian
> >>>
> >>>
> >>> _______________________________________________
> >>> openwrt-devel mailing list
> >>> openwrt-devel at lists.openwrt.org
> >>> https://lists.openwrt.org/mailman/listinfo/openwrt-devel
> >
> >



_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel