[OpenWrt-Devel] ag71xx: fix return value check in ag71xx_probe()
Petr Štetiar
ynezz at true.cz
Tue Feb 11 05:36:28 EST 2020
Rosen Penev <rosenp at gmail.com> [2020-02-06 19:31:40]:
Hi,
> In case of error, the function of_get_mac_address() returns ERR_PTR()
> and never returns NULL. The NULL test in the return value check should
> be replaced with IS_ERR().
thanks for your effort, but that is not applicable to 4.19 as the
of_get_mac_address returns ERR_PTR since d01f449c008a ("of_net: add NVMEM
support to of_get_mac_address"). Seems like 5.4 has already the fix.
-- ynezz
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel
More information about the openwrt-devel
mailing list