[PATCH 1/3] ramips: add support for the RT6855A SoC

[Rafaël Carré]

Hello,

Thank you for your comments, they are very much appreciated!

On 12/24/20 04:09, Chuanhong Guo wrote:
> Hi!
> 
> On Thu, Dec 24, 2020 at 12:51 AM Rafaël Carré <funman at videolan.org> wrote:
>>
>> Add Linksys WAP300N target

>> +        ethernet: ethernet at 50000{
>> +            compatible = "ralink,rt6855-eth";
> 
> This doesn't match your compatible string choice in the ethernet driver.

Indeed.

As I said in an earlier mail, I did not find yet how the OpenWrt .dts 
takes precedence over the in-tree one.

All the needed declarations are in the in-tree .dts, including 
OpenWrt-specific ones.

I will look at this before sending another patch.


>> diff --git a/target/linux/ramips/dts/rt6855a_linksys_wap300n.dts b/target/linux/ramips/dts/rt6855a_linksys_wap300n.dts
>> new file mode 100644
>> index 0000000000..d923946c4a
>> --- /dev/null
>> +++ b/target/linux/ramips/dts/rt6855a_linksys_wap300n.dts
>> @@ -0,0 +1,18 @@
>> +// SPDX-License-Identifier: GPL-2.0
>> +/dts-v1/;
>> +
>> +/include/ "rt6855.dtsi"
>> +
>> +/ {
>> +       compatible = "ralink,rt6855-soc";
>> +       model = "Linksys WAP300n";
>> +
>> +       memory at 0 {
>> +               device_type = "memory";
>> +               reg = <0x20000 0x3fe0000>;
>> +       };
>> +
>> +       chosen {
>> +               bootargs = "console=ttyS0,57600";
>> +       };
>> +};
> 
> Seems incomplete?

It's quite possible some things need to move from rt6855a.dtsi into this 
file. Will look at this as well.