[PATCH] kernel: add module for tcp-hybla congestion control algorithm

Hauke Mehrtens hauke at hauke-m.de
Wed Dec 23 07:08:55 EST 2020


On 12/23/20 8:36 AM, Yousong Zhou wrote:
> Just the module and no default sysctl conf file is provided
> 
> Ref: https://forum.openwrt.org/t/20-xx-tcp-hybla/83076
> Signed-off-by: Yousong Zhou <yszhou4tech at gmail.com>
> ---
>   package/kernel/linux/modules/netsupport.mk | 20 ++++++++++++++++++++
>   1 file changed, 20 insertions(+)
> 
> diff --git a/package/kernel/linux/modules/netsupport.mk b/package/kernel/linux/modules/netsupport.mk
> index 0c68b394d1..156892c952 100644
> --- a/package/kernel/linux/modules/netsupport.mk
> +++ b/package/kernel/linux/modules/netsupport.mk
> @@ -949,6 +949,26 @@ endef
>   $(eval $(call KernelPackage,tcp-bbr))
>   
>   
> +define KernelPackage/tcp-hybla
> +  SUBMENU:=$(NETWORK_SUPPORT_MENU)
> +  TITLE:=TCP-Hybla congestion control algorithm
> +  KCONFIG:= \
> +	CONFIG_TCP_CONG_ADVANCED=y \

This is already set in the generic configuration for most targets:
-----------------
:~/openwrt/openwrt/target/linux$ git grep TCP_CONG_ADVANCED
generic/config-5.4:CONFIG_TCP_CONG_ADVANCED=y
layerscape/armv7/config-5.4:# CONFIG_TCP_CONG_ADVANCED is not set
layerscape/armv8_64b/config-5.4:# CONFIG_TCP_CONG_ADVANCED is not set
zynq/config-5.4:# CONFIG_TCP_CONG_ADVANCED is not set
---------------

I would prefer if we set if for all targets, then it is not needed here 
any more.


> +	CONFIG_TCP_CONG_HYBLA
> +  FILES:=$(LINUX_DIR)/net/ipv4/tcp_hybla.ko
> +  AUTOLOAD:=$(call AutoLoad,74,tcp_hybla)

Is AutoProbe working here?

> +endef
> +
> +define KernelPackage/tcp-hybla/description
> +  TCP-Hybla is a sender-side only change that eliminates penalization of
> +  long-RTT, large-bandwidth connections, like when satellite legs are
> +  involved, especially when sharing a common bottleneck with normal
> +  terrestrial connections.
> +endef
> +
> +$(eval $(call KernelPackage,tcp-hybla))
> +
> +
>   define KernelPackage/ax25
>     SUBMENU:=$(NETWORK_SUPPORT_MENU)
>     TITLE:=AX25 support
> 




More information about the openwrt-devel mailing list