ramips mt7621 kernel crash related to TSO on 19.07

[Baptiste Jonglez]

Hi,

OpenWrt 19.07 on mt7621 can sometimes crash under load.  It does not
trigger often so it might go unnoticed, but there are multiple reports of
this issue and I also experienced it on a device.

Here is an example crash log:

  https://bugs.openwrt.org/index.php?getfile=1116

Somebody managed to workaround the issue by disabling TSO in the ethernet
driver:

  https://bugs.openwrt.org/index.php?do=details&task_id=2628

Does that sound like a proper fix, or would it rather be a symptom for
another issue?

As far as I understand, the mt7621 ethernet driver in 19.07 is not the
same as the one in master.  The upstream driver used in master seems to
enable TSO support:

  https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/tree/drivers/net/ethernet/mediatek/mtk_eth_soc.h?h=linux-5.4.y#n36

Thanks,
Baptiste
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.openwrt.org/pipermail/openwrt-devel/attachments/20201222/305aac53/attachment.sig>