R: [PATCH] tools: zlib: fix broken compile with ccache enabled

[ansuelsmth at gmail.com]

> On Thu, Dec 17, 2020 at 5:15 PM <ansuelsmth at gmail.com> wrote:
> >
> > > On Thu, Dec 17, 2020 at 4:13 PM <ansuelsmth at gmail.com> wrote:
> > > >
> > > >
> > > >
> > > > > -----Messaggio originale-----
> > > > > Da: Ansuel Smith <ansuelsmth at gmail.com>
> > > > > Inviato: venerdì 18 dicembre 2020 00:59
> > > > > A: OpenWrt Development List <openwrt-devel at lists.openwrt.org>
> > > > > Cc: Ansuel Smith <ansuelsmth at gmail.com>
> > > > > Oggetto: [PATCH] tools: zlib: fix broken compile with ccache enabled
> > > > >
> > > > > If ccache is enabled with an empty buildroot the compilation fails. Fix
> > > > > this by using the NOCACHE compiler as it's done by other tools package.
> > > > >
> > > > > Signed-off-by: Ansuel Smith <ansuelsmth at gmail.com>
> > > > > ---
> > > > >  tools/zlib/Makefile | 1 +
> > > > >  1 file changed, 1 insertion(+)
> > > > >
> > > > > diff --git a/tools/zlib/Makefile b/tools/zlib/Makefile
> > > > > index 279851f..5dc311d 100644
> > > > > --- a/tools/zlib/Makefile
> > > > > +++ b/tools/zlib/Makefile
> > > > > @@ -22,6 +22,7 @@ PKG_CPE_ID:=cpe:/a:gnu:zlib
> > > > >  include $(INCLUDE_DIR)/host-build.mk
> > > > >  include $(INCLUDE_DIR)/cmake.mk
> > > > >
> > > > > +CMAKE_HOST_C_COMPILER:=$(HOSTCC_NOCACHE)
> > > > >  HOST_CFLAGS +=-fPIC
> > > > >
> > > > >  define Host/Install
> > > > > --
> > > > > 2.29.2
> > > >
> > > > Ignore, it seems it cause other problem with cmake?
> > > You're missing -D and CMAKE_HOST_OPTIONS.
> > >
> > > I submitted a patch that fixes this. Tested on Fedora 33.
> >
> > I'm testing this with the other package. I could be very wrong but it
> > seems that ccache is just broken with cmake. My current implementation
> > is a variable CMAKE_NOCCACHE that disable the use of ccache for that
> > package. For now I found that this is needed for both the host build and the
> > pkg build. (libubox, opkg, libjson-c affected) Can you check if you can
> > compile that package with not problem with your implementation. Just
> > to make sure I'm not making things wrong.
> Looks like this is not right either.
> 
> That cmake bump is what broke ccache.
> 
> More info:
> https://github.com/openwrt/openwrt/commit/bfc433efd4a0c6875a92981d1bd
> 2a5e3e60c61c6#commitcomment-45228331
> 

Can confirm that the proposed change in the comment fix the problem and pkg that
use cmake are compiled.