[PATCH] uhttpd: don't redirect to HTTPS by default

[Petr Štetiar]

Jo-Philipp Wich <jo at mein.io> [2020-12-14 23:24:23]:

Hi,

> > So we can ship px5g-wolfssl by default in the release image, but still
> > make the HTTPS for LuCI optional. This small change with addition of
> > `CONFIG_PACKAGE_px5g-wolfssl=y` into the buildbot's seed config for the
> > next release should provide optional HTTPS in the next release.
> 
> please note that LuCI is currently quite broken using the libustream-wolfssl
> backend, definitely not in a releasable shape.

I'm hearing you, that's why I've proposed this change, to make it opt-in.

Without this change the HTTPS would be enabled by default and this is not
desired.  With this change it's strictly opt-in, so we can mention it in the
relase notes, that HTTPS is available if folks want to try it out and send
patches with fixes or just file bug reports.

Speaking of bug reports, what does it mean "currently quite broken"? Do you've
some reproducer or some idea how to trigger that issue(s) you're seeing? It
would be nice to have those cases covered in unit tests.

BTW I'm using LuCI with HTTPS for some time and apart from that sysauth cookie
issue which is not related to libustream-wolfssl backend it seems quite usable
to me, no memleaks etc.

Cheers,

Petr