[luci PATCH 05/13] luci-mod-status: use the new ubus dsl metrics
Jo-Philipp Wich
jo at mein.io
Fri Dec 11 07:11:05 EST 2020
Hi,
> This is significantly faster.
great work! I like it :)
Minor nitpick below.
> [...]
> -var callLuciDSLStatus = rpc.declare({
> - object: 'luci-rpc',
> - method: 'getDSLStatus',
> +var call_dsl_metrics = rpc.declare({
> + object: 'dsl',
> + method: 'metrics',
> expect: { '': {} }
> });
Please keep the camel case notation to align with the other RPC method
declarations in the tree, so `s/call_dsl_metrics/callDSLMetrics/g`
~ Jo
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <http://lists.openwrt.org/pipermail/openwrt-devel/attachments/20201211/87655106/attachment.sig>
More information about the openwrt-devel
mailing list