[PATCH] ramips/mt7621: refresh the kernel config

Felix Fietkau nbd at nbd.name
Wed Dec 2 13:24:53 EST 2020


Hi,


On 2020-12-02 18:32, Adrian Schmutzler wrote:
>> -----Original Message-----
>> From: openwrt-devel [mailto:openwrt-devel-bounces at lists.openwrt.org]
>> On Behalf Of Rui Salvaterra
>> Sent: Mittwoch, 2. Dezember 2020 16:42
>> To: openwrt-devel at lists.openwrt.org
>> Cc: Rui Salvaterra <rsalvaterra at gmail.com>
>> Subject: [PATCH] ramips/mt7621: refresh the kernel config
>> 
>> The removed config symbols are already enabled by the generic kernel
>> configuration (or by default), while the added ones are forcefully enabled by
>> the specific architecture.
> 
> as already discussed on IRC, this is removing a lot of symbols, which makes not much sense to me.
> 
> It appears that this commit broke the behavior of "make kernel_oldconfig":
> 
> https://github.com/openwrt/openwrt/commit/a8fb12a7d62c94fd1bbda332752e0f8c794f3702
> 
> Just reverting that commit results in something that "looks reasonable" after make kernel_oldconfig.
> 
> I'm marking that patch with "changes requested", though it's not really Rui's fault in the first place.
> 
> Let's see where this evolves to.
Removing a lot of symbols was the whole point behind my commit, and it
makes sense that any subsequent refresh has a big negative delta.

I tried to be careful about only filtering out auto-generated symbols.
Did I accidentally hit any symbol with a prompt that shows up on make
afterwards?

- Felix



More information about the openwrt-devel mailing list