[OpenWrt-Devel] [PATCH 2/2] ramips: mt7621: use lzma-loader for D-Link DIR-860L

[mail at adrianschmutzler.de]

Hi,

> -----Original Message-----
> From: openwrt-devel [mailto:openwrt-devel-bounces at lists.openwrt.org]
> On Behalf Of Szabolcs Hubai
> Sent: Sonntag, 19. April 2020 02:37
> To: openwrt-devel at lists.openwrt.org
> Cc: Szabolcs Hubai <szab.hu at gmail.com>
> Subject: [OpenWrt-Devel] [PATCH 2/2] ramips: mt7621: use lzma-loader for
> D-Link DIR-860L
> 
> This device has trouble extracting big kernel from flash, and supports LZMA
> compressed kernels only.
> 
> Using OpenWrt kernel loader saves us 64 KB compared to the dictionary size
> limiting workaround.
> 
> Factory image sizes (commit: 5f126c541a74) with "CONFIG_ALL_KMODS=y":
> - original ("-d23", default): 4784188 bytes, LZMA ERROR 1
> - with "-d19": 4915260, LZMA ERROR 1
> - with "-d18": 4915260, diff to original: +128 KB
> - with "-d17": 4980796, diff to original: +192 KB
> - with this patch: 4849724, diff to original: +64 KB
> 
> To save some CPU cycle, use minimal compression ("-a0") for the LZMA
> compressed uImage.
> 
> Signed-off-by: Szabolcs Hubai <szab.hu at gmail.com>
> ---
>  target/linux/ramips/image/mt7621.mk | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/target/linux/ramips/image/mt7621.mk
> b/target/linux/ramips/image/mt7621.mk
> index aa6836d50a..28d2637bd3 100644
> --- a/target/linux/ramips/image/mt7621.mk
> +++ b/target/linux/ramips/image/mt7621.mk
> @@ -216,9 +216,10 @@ TARGET_DEVICES += buffalo_wsr-600dhp
> 
>  define Device/dlink_dir-860l-b1
>    $(Device/seama)
> +  $(Device/lzma-loader)

I do not really see the benefit of having this definition if you have to modify it below anyway.
Having seen this, I'd prefer to drop patch 1/2 entirely and just add the necessary adjustments directly to this particular device:

LOADER_TYPE := bin
KERNEL := kernel-bin | append-dtb | lzma | loader-kernel | relocate-kernel | lzma -a0 | uImage lzma
(properly wrapped of course)

If we have five devices like this at some point, I'll be happy to discuss how we can create a shared recipe.

Best

Adrian

>    BLOCKSIZE := 64k
>    SEAMA_SIGNATURE := wrgac13_dlink.2013gui_dir860lb
> -  KERNEL := kernel-bin | append-dtb | relocate-kernel | lzma | uImage lzma
> +  KERNEL += | relocate-kernel | lzma -a0 | uImage lzma
>    IMAGE_SIZE := 16064k
>    DEVICE_VENDOR := D-Link
>    DEVICE_MODEL := DIR-860L
> --
> 2.17.1
> 
> 
> _______________________________________________
> openwrt-devel mailing list
> openwrt-devel at lists.openwrt.org
> https://lists.openwrt.org/mailman/listinfo/openwrt-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: openpgp-digital-signature.asc
Type: application/pgp-signature
Size: 834 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/openwrt-devel/attachments/20200419/1549c865/attachment.sig>
-------------- next part --------------
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel