[OpenWrt-Devel] [PATCH][RFC] Revert "ramips: mt7621: disable image for mikrotik_rbm11g"

Tue Apr 7 04:20:00 EDT 2020

Hi,

> -----Original Message-----
> From: openwrt-devel [mailto:openwrt-devel-bounces at lists.openwrt.org]
> On Behalf Of Chuanhong Guo
> Sent: Dienstag, 7. April 2020 04:27
> To: openwrt-devel at lists.openwrt.org
> Cc: Chuanhong Guo <gch981213 at gmail.com>
> Subject: [OpenWrt-Devel] [PATCH][RFC] Revert "ramips: mt7621: disable
> image for mikrotik_rbm11g"
> 
> This reverts commit 838f1fbb50e91ebaf1d34f9666ae6b65eb49df5c.
> 
> It can be guessed from Mikrotik GPL kernel that this router uses port0.
> And even if it doesn't, RBM11G has easy-to-use tftp recovery mechanism for
> users to restore their firmware. Let's enable this image and see if users
> complains.
> 
> Signed-off-by: Chuanhong Guo <gch981213 at gmail.com>
> ---
> RFC: Should I do this?
> If I don't do so, users will complain about missing image; But if I do and brick
> users devices, users may also complain. That may not be a big deal as users
> can recover their devices easily.
> I have no idea what I should do at this moment.

IMO, if you have a chance for an educated guess, it's better to have the image available (just as you justified it in the actual commit message).
Due to the DSA introduction, users will have to do more conscious updates anyway.

Acked-by: Adrian Schmutzler <freifunk at adrianschmutzler.de>

Best

Adrian

> 
> It's even better if a developer with this device can spot this mail and help
> testing the firmware :D
> 
>  target/linux/ramips/image/mt7621.mk | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/target/linux/ramips/image/mt7621.mk
> b/target/linux/ramips/image/mt7621.mk
> index cdae42f3e4..a4484b408f 100644
> --- a/target/linux/ramips/image/mt7621.mk
> +++ b/target/linux/ramips/image/mt7621.mk
> @@ -497,7 +497,6 @@ TARGET_DEVICES += mikrotik_rb750gr3  define
> Device/mikrotik_rbm11g
>    $(Device/MikroTik)
>    DEVICE_MODEL := RouterBOARD M11G
> -  DEFAULT := n # disabled due to unknown port assignment  endef
> TARGET_DEVICES += mikrotik_rbm11g
> 
> --
> 2.25.1
> 
> 
> _______________________________________________
> openwrt-devel mailing list
> openwrt-devel at lists.openwrt.org
> https://lists.openwrt.org/mailman/listinfo/openwrt-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: openpgp-digital-signature.asc
Type: application/pgp-signature
Size: 834 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/openwrt-devel/attachments/20200407/b0764261/attachment.sig>
-------------- next part --------------
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel