[OpenWrt-Devel] Fwd: [PATCH v2] mvebu: add support for Buffalo LinkStation LS421DE

[Daniel González Cabanelas]

Hi Tomasz

El dom., 5 abr. 2020 a las 20:06, Tomasz Maciej Nowak
(<tomek_n at o2.pl>) escribió:
>
> W dniu 03.04.2020 o 19:22, Daniel González Cabanelas pisze:
> > Thanks for being precise. I already tuned again the dts file with your
> > instructions. I'll delete the nls modules, and include kmod-md-mod,
> > kmod-md-raid0 and kmod-md-raid1 which are used by the stock firmware
> > for managing the SATA drives.
> >
> > I also noticed that this board comes with the GPIO4  enabled for
> > supoorting the CPU power down. For enabling this pinmux right now I'm
> > using this dts code:
> >
> > ....................
> > &pmsu {
> >      pinctrl-0 = <&pmx_power_cpu>;
> >      pinctrl-names = "default";
> > };
> >
> > &pinctrl {
> >     pmx_power_cpu: pmx-power-cpu {
> >     marvell,pins = "mpp4";
> >    marvell,function = "cpu_pd";
>
> Shoudln't it be "cpu-pd"?

I commited a mistake, but in fact it should be vdd :
https://elixir.bootlin.com/linux/v4.19.114/source/drivers/pinctrl/mvebu/pinctrl-armada-370.c#L42

>
> > };
> > ................
> >
> > Is this the righ way to do it?.
>
> Looks OK, there's nothing wrong with defining relevant bits in dts,
> if they are correct.
>
> > BTW, the board works ok without it enabled by Openwrt,
>
> Maybe the driver already uses it since only one pin is defined as
> "cpu-pd"?

I don't see any reference to this pin in this driver. I assumed this
feature is hardware controlled.

Another issue, I can't deselect the kmod-usb3 from the image creation
without loosing the front port, because it's not part of SoC but an IC
connected to a PCI bus. And the kernel does not select CONFIG_USB_PCI
by default.
Thus I'll include this module in the image creation.

Regards.
Daniel

_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel