[OpenWrt-Devel] Negative offset for checksum in ath79's 10-ath9k-eeprom

[Adrian Schmutzler]

Hi,

> -----Original Message-----
> From: openwrt-devel [mailto:openwrt-devel-bounces at lists.openwrt.org] On Behalf Of David Bauer
> Sent: Mittwoch, 18. September 2019 17:04
> To: Adrian Schmutzler <mail at adrianschmutzler.de>
> Cc: openwrt-devel at lists.openwrt.org; 'Chuanhong Guo' <gch981213 at gmail.com>; 'Sebastian Kemper' <sebastian_ml at gmx.net>;
> 'Christian Lamparter' <chunkeey at gmail.com>
> Subject: Re: [OpenWrt-Devel] Negative offset for checksum in ath79's 10-ath9k-eeprom
> 
> Hello Adrian,
> 
> On 9/18/19 4:54 PM, Adrian Schmutzler wrote:
> > From a practical perspective, it does not matter which function is used, because the checksum is not evaluated. So one could use
> either ath10kcal_patch_mac or ath10kcal_patch_mac_crc in all cases and would get the same result (in terms of functionality).
> 
> ath10kcal_patch_mac_crc is not nearly as old as ath10kcal_patch_mac. ath10kcal_patch_mac_crc is a requirement for 2nd generation
> 802.11ac chips which require a bdf in addition to the eeprom-caldata. First generation chips do not have this requirement.

Okay.

I think I will add a migration to crc for the ath10k functions to my caldata-unification patchset. I will resend that one anyway after my recent fixes (checksum hex2dec and ath9k crc fix) are merged.

Best

Adrian

> 
> Best wishes
> David
> 
> _______________________________________________
> openwrt-devel mailing list
> openwrt-devel at lists.openwrt.org
> https://lists.openwrt.org/mailman/listinfo/openwrt-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: openpgp-digital-signature.asc
Type: application/pgp-signature
Size: 834 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/openwrt-devel/attachments/20190918/a4c433c0/attachment.sig>
-------------- next part --------------
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel