[OpenWrt-Devel] [PATCH v2 1/2] ath79: use board name in LED migrations

Adrian Schmutzler freifunk at adrianschmutzler.de
Tue Sep 17 08:42:59 EDT 2019


Several devices added to LED migration script will just have their
(old) board name converted to tp-link.

By using a variable for this, the amount of code in the migration
script can be reduced and the chance for typos is reduced.

This patch also introduces the marker for beginning of a pattern
"^" to the regex, so the match is more specific.

Signed-off-by: Adrian Schmutzler <freifunk at adrianschmutzler.de>
---
 .../ath79/base-files/etc/uci-defaults/04_led_migration     | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/target/linux/ath79/base-files/etc/uci-defaults/04_led_migration b/target/linux/ath79/base-files/etc/uci-defaults/04_led_migration
index b1afd0ee76..4e4e91c788 100644
--- a/target/linux/ath79/base-files/etc/uci-defaults/04_led_migration
+++ b/target/linux/ath79/base-files/etc/uci-defaults/04_led_migration
@@ -4,6 +4,7 @@
 . /lib/functions/migrations.sh
 
 board=$(board_name)
+boardonly="${board##*,}"
 
 case "$board" in
 engenius,epg5000)
@@ -12,11 +13,9 @@ engenius,epg5000)
 tplink,archer-c7-v2)
 	migrate_leds ":blue:=:green:"
 	;;
-tplink,archer-c7-v4)
-	migrate_leds "archer-c7-v4:=tp-link:"
-	;;
+tplink,archer-c7-v4|\
 tplink,archer-c7-v5)
-	migrate_leds "archer-c7-v5:=tp-link:"
+	migrate_leds "^$boardonly:=tp-link:"
 	;;
 tplink,re355-v1)
 	migrate_leds "re355:=tp-link:"
-- 
2.20.1


_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel



More information about the openwrt-devel mailing list