[OpenWrt-Devel] kernel: bump 4.19 to 4.19.72 broke ath79

[Koen Vandeputte]

On 14-09-19 12:47, Magnus Kroken wrote:
> Hi Andre
>
> On 14.09.2019 10:49, Andre Valentin wrote:
>> It seems the kernel bump broke ath79 compilation. The problem lies in
>> target/linux/ath79/patches-4.19/0028-MIPS-ath79-drop-machfiles.patch
>>
>> It cannot be applied anymore. I tried a quick fix, but there seems to 
>> be a bigger change.
>
> The culprit isn't the kernel update, but this commit:
> 00d48bcac0 ar71xx: Fix potentially missed IRQ handling during dispatch
>
> Koen (or anyone else), can you shed some light on this one? I mostly 
> poke at kernel patches until something happens, I don't really 
> understand hardware/kernel well. Some things jump out:
>
Hi,

Sorry about that.

ath79 contained a patch which removes the legacy irq code, which is 
being altered in the fix.

Hence the patch during build of ath79 didn't apply.

I didn't notice it, as this removal was only upstreamed in 5.0 and it's 
strictly not needed to remove it, as it's simply unused over there.

Fixes has been pushed for master and 19.07.

Regards,

Koen

> 1. The commit message is labeled ar71xx, but the patch is applied to 
> the generic target. It patches kernel files that IIUC are used by both 
> ath79 and ar71xx targets.
> 2. It modifies arch/mips/ath79/irq.c. The patch that fails on ath79, 
> 0027-MIPS-ath79-drop-legacy-IRQ-code, deletes this file completely 
> (which now fails, as the file content is changed by 
> 343-MIPS-ath79-Fix-potentially-missed-IRQ-handling-durin.patch).
>
>> Kind regards,
>>
>> André
>
> Regards,
> Magnus Kroken

_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel