[OpenWrt-Devel] [PATCH] firewall3: fix typo that affects ICMPv6 rules with numeric icmp_type
Alin Nastac
alin.nastac at gmail.com
Tue Sep 10 10:15:13 EDT 2019
From: Alin Nastac <alin.nastac at gmail.com>
Problem can be reproduced with a rule like this:
option src 'wan'
option family 'ipv6'
option proto 'icmp'
option icmp_type '128'
option target 'DROP'
The resulted rule will set --icmpv6-type to 128/255.
Signed-off-by: Alin Nastac <alin.nastac at gmail.com>
---
options.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/options.c b/options.c
index c763d9e..7870143 100644
--- a/options.c
+++ b/options.c
@@ -568,7 +568,7 @@ fw3_parse_icmptype(void *ptr, const char *val, bool is_list)
}
icmp.type6 = icmp.type;
- icmp.code6_min = icmp.code_max;
+ icmp.code6_min = icmp.code_min;
icmp.code6_max = icmp.code_max;
v4 = true;
--
2.7.4
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel
More information about the openwrt-devel
mailing list