[OpenWrt-Devel] [PATCH] scripts/feeds: fix 'src-include' directive

Bjørn Mork bjorn at mork.no
Mon Sep 2 07:49:21 EDT 2019


Commit 775b70f8d5df renamed parse_file() parameters without
updating the recursive call. This broke parsing of any feeds.conf
using 'src-include'.

 $ scripts/feeds update -a
 Can't use string ("defaults") as a HASH ref while "strict refs" in use at scripts/feeds line 63, <$fh> line 1.

Fixes: 775b70f8d5df ("scripts/feeds: allow adding parameters to feeds")
Signed-off-by: Bjørn Mork <bjorn at mork.no>
---
 scripts/feeds | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/feeds b/scripts/feeds
index e36e044a11a8..8de4075bc7ed 100755
--- a/scripts/feeds
+++ b/scripts/feeds
@@ -75,7 +75,7 @@ sub parse_file($$) {
 		}
 
 		if ($type eq "include") {
-			parse_file($urls, $name) or
+			parse_file($urls, $existing) or
 			    die "Unable to open included file '$urls'";
 			next;
 		}
-- 
2.20.1


_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel


More information about the openwrt-devel mailing list