[OpenWrt-Devel] [PATCH 3/3] ipq40xx: ipq4019: Add new device Compex WPJ419

[Adrian Schmutzler]

Hi,

> > +			m25p80 at 0 {
> > +				#address-cells = <1>;
> > +				#size-cells = <1>;
> > +				reg = <0>;
> > +				linux,modalias = "m25p80", "n25q128a11";
> > +				compatible = "jedec,spi-nor", "n25q128a11";
> > +				spi-max-frequency = <24000000>;
> 
> 
> I don't think you need linux,modalias here, nor the chip type in the
> compatible line.
> I believe that the following compatible line is sufficient
> 
>      compatible = "jedec,spi-nor";
> 
> 
> You might also want to consider "flash at 0" or "nor at 0" or "nor_flash at 0",
> or the like, rather than a chip-specific name. (I'm not a committer.)

Indeed.

Best

Adrian 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: openpgp-digital-signature.asc
Type: application/pgp-signature
Size: 834 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/openwrt-devel/attachments/20191030/a0d2af42/attachment.sig>
-------------- next part --------------
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel