[OpenWrt-Devel] [PATCH 3/3] ipq40xx: ipq4019: Add new device Compex WPJ419

[Adrian Schmutzler]

Hi,

just some cosmetical drive-by comments below:

...
> diff --git a/target/linux/ipq40xx/base-files/etc/hotplug.d/firmware/11-ath10k-caldata b/target/linux/ipq40xx/base-
> files/etc/hotplug.d/firmware/11-ath10k-caldata
> index 2336ef3c7b..b18d17e422 100644
> --- a/target/linux/ipq40xx/base-files/etc/hotplug.d/firmware/11-ath10k-caldata
> +++ b/target/linux/ipq40xx/base-files/etc/hotplug.d/firmware/11-ath10k-caldata
> @@ -71,6 +71,7 @@ case "$FIRMWARE" in
>  		/usr/bin/fritz_cal_extract -i 1 -s 0x3D000 -e 0x207 -l 12064 -o /lib/firmware/$FIRMWARE $(find_mtd_chardev
> "urlader1")
>  		;;
>  	compex,wpj428 |\
> +	compex,wpj419 |\

Please apply correct alphabetic sorting.

>  	engenius,eap1300 |\
>  	openmesh,a42 |\
>  	openmesh,a62 |\
> @@ -134,6 +135,7 @@ case "$FIRMWARE" in
>  		/usr/bin/fritz_cal_extract -i 1 -s 0x3C000 -e 0x208 -l 12064 -o /lib/firmware/$FIRMWARE $(find_mtd_chardev
> "urlader1")
>  		;;
>  	compex,wpj428 |\
> +	compex,wpj419 |\

Please apply correct alphabetic sorting.

>  	engenius,eap1300 |\
>  	openmesh,a42 |\
>  	openmesh,a62 |\
> diff --git a/target/linux/ipq40xx/config-4.19 b/target/linux/ipq40xx/config-4.19
> index 8948b73ff7..3ee921abed 100644
> --- a/target/linux/ipq40xx/config-4.19
> +++ b/target/linux/ipq40xx/config-4.19
> @@ -303,6 +303,9 @@ CONFIG_MTD_NAND_ECC=y
>  CONFIG_MTD_NAND_QCOM=y
>  CONFIG_MTD_SPI_NAND=y
>  CONFIG_MTD_SPI_NOR=y
> +CONFIG_MTD_SPINAND_MT29F=y
> +CONFIG_MTD_SPINAND_GIGADEVICE=y
> +CONFIG_MTD_SPINAND_ONDIEECC=y
>  CONFIG_MTD_SPLIT_FIRMWARE=y
>  CONFIG_MTD_SPLIT_FIT_FW=y
>  CONFIG_MTD_UBI=y
> diff --git a/target/linux/ipq40xx/files-4.19/arch/arm/boot/dts/qcom-ipq4019-bus.dtsi b/target/linux/ipq40xx/files-
> 4.19/arch/arm/boot/dts/qcom-ipq4019-bus.dtsi
> new file mode 100644
> index 0000000000..169505973f
> --- /dev/null
> +++ b/target/linux/ipq40xx/files-4.19/arch/arm/boot/dts/qcom-ipq4019-bus.dtsi
> @@ -0,0 +1,1142 @@
> +/* Copyright (c) 2015, The Linux Foundation. All rights reserved.
> + *
> + * Permission to use, copy, modify, and/or distribute this software for any
> + * purpose with or without fee is hereby granted, provided that the above
> + * copyright notice and this permission notice appear in all copies.
> + *
> + * THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
> + * WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
> + * MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR
> + * ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
> + * WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN
> + * ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
> + * OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
> + *
> + */
> +
> +#include <dt-bindings/msm/msm-bus-ids.h>
> +
> +/ {
> +
> +soc {

Child nodes  (=soc) should be indented.

> +	ad_hoc_bus: ad-hoc-bus {
> +		compatible = "qcom,msm-bus-device";
...

> diff --git a/target/linux/ipq40xx/files-4.19/arch/arm/boot/dts/qcom-ipq4019-wpj419.dts b/target/linux/ipq40xx/files-
> 4.19/arch/arm/boot/dts/qcom-ipq4019-wpj419.dts
> new file mode 100644
> index 0000000000..5553bbd166
> --- /dev/null
> +++ b/target/linux/ipq40xx/files-4.19/arch/arm/boot/dts/qcom-ipq4019-wpj419.dts
> @@ -0,0 +1,371 @@
...
> +&gmac0 {
> +qcom,phy_mdio_addr = <4>;
> +qcom,poll_required = <1>;
> +qcom,forced_speed = <1000>;
> +qcom,forced_duplex = <1>;
> +vlan_tag = <2 0x20>;
> +};
> +
> +&gmac1 {
> +qcom,phy_mdio_addr = <3>;
> +qcom,poll_required = <1>;
> +qcom,forced_speed = <1000>;
> +qcom,forced_duplex = <1>;
> +vlan_tag = <1 0x10>;
> +};
> +
> +&wifi0 {
> +status = "okay";
> +};
> +
> +&wifi1 {
> +status = "okay";
> +};

Fix indent for the content of the four nodes above.

> diff --git a/target/linux/ipq40xx/files-4.19/include/dt-bindings/msm/msm-bus-ids.h b/target/linux/ipq40xx/files-4.19/include/dt-
> bindings/msm/msm-bus-ids.h
> new file mode 100644
> index 0000000000..da0b83e831
> --- /dev/null
> +++ b/target/linux/ipq40xx/files-4.19/include/dt-bindings/msm/msm-bus-ids.h
...
> +#define	MSM_BUS_SLAVE_CATS_128 663
> +#define	MSM_BUS_SLAVE_OCMEM_64 664
> +#define MSM_BUS_SLAVE_PCIE_0 665
> +#define MSM_BUS_SLAVE_PCIE_1 666

Mixed indent here ...

...
> +#define	MSM_BUS_SLAVE_SRVC_SNOC 754
> +
> +#define	MSM_BUS_SYSTEM_FPB_SLAVE_SYSTEM  MSM_BUS_SYSTEM_SLAVE_SYSTEM_FPB
> +#define MSM_BUS_CPSS_FPB_SLAVE_SYSTEM MSM_BUS_SYSTEM_SLAVE_CPSS_FPB

and here.

...
> diff --git a/target/linux/ipq40xx/image/Makefile b/target/linux/ipq40xx/image/Makefile
> index ed46bca649..a13a17b3cf 100644
> --- a/target/linux/ipq40xx/image/Makefile
> +++ b/target/linux/ipq40xx/image/Makefile
> @@ -179,6 +179,20 @@ define Device/compex_wpj428
>  endef
>  TARGET_DEVICES += compex_wpj428
> 
> +define Device/compex_wpj419
> +	$(call Device/FitImage)
> +	$(call Device/UbiFit)
> +	DEVICE_VENDOR := Compex
> +	DEVICE_MODEL := WPJ419
> +	DEVICE_DTS := qcom-ipq4019-wpj419
> +	DEVICE_DTS_CONFIG := config at 12
> +	KERNEL_INSTALL := 1
> +	BLOCKSIZE := 128k
> +	PAGESIZE := 2048
> +	FILESYSTEMS := squashfs
> +endef
> +TARGET_DEVICES += compex_wpj419

Please use correct sorting for the node (before wpj428).
IMAGE_SIZE is missing compared to wpj428, I have not checked whether it is required.

Best

Adrian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: openpgp-digital-signature.asc
Type: application/pgp-signature
Size: 834 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/openwrt-devel/attachments/20191030/99b93a12/attachment.sig>
-------------- next part --------------
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel