[OpenWrt-Devel] [PATCH] ath79: add support for ZyXEL NWA1123-NI

[Adrian Schmutzler]

Hi,

> +			partition at 50000 {
> +				compatible = "denx,uimage";
> +				label = "firmware";
> +				reg = <0x050000 0xF50000>;

I'd prefer lower-case for the address (and for consistency with your other definitions).

> +			art: partition at ff0000 {
> +				label = "ART";

Please use lower case here. This is used consistently across ath79 target.

> +				reg = <0xff0000 0x010000>;
> +				read-only;
> +			};
> +		};
> +	};
> +};
> +
> +
> +&pcie {
> +	status = "okay";
> +
> +	wifi at 0,0 {
> +		compatible = "168c,0030";
> +		reg = <0x0000 0 0 0 0>;
> +		mtd-mac-address = <&art 0x1002>;
> +		mtd-mac-address-increment = <2>;
> +		qca,disable-2ghz;

No caldata extraction? Or am I missing something?

> +	};
> +};
> +
> +&wmac {
> +	status = "okay";
> +	qca,disable-5ghz;
> +	mtd-cal-data = <&art 0x1000>;
> +	mtd-mac-address = <&art 0x1002>;
> +	mtd-mac-address-increment = <1>;

Normally, 0x1002 is the address read automatically when mtd-cal-data is 0x1000. It is very unlikely that vendor initializes an address to the correct location and then overwrites it with an increment.

Please provide the MAC address assignment with vendor firmware.
Based on that information, check whether you find those addresses in art (with hexdump, or by reading typical locations). For reference, check out https://openwrt.org/docs/guide-developer/mac.address

After that, please share the results with us.

Best

Adrian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: openpgp-digital-signature.asc
Type: application/pgp-signature
Size: 834 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/openwrt-devel/attachments/20191025/3a9847f0/attachment.sig>
-------------- next part --------------
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel