[OpenWrt-Devel] [PATCH fwtool 3/8] iron out extra compiler warnings

Petr Štetiar ynezz at true.cz
Wed Oct 23 06:53:34 EDT 2019


 fwtool.c:216:3: error: ignoring return value of ‘ftruncate’, declared with attribute warn_unused_result [-Werror=unused-result]
 fwtool.c:376:3: error: ignoring return value of ‘ftruncate’, declared with attribute warn_unused_result [-Werror=unused-result]

Signed-off-by: Petr Štetiar <ynezz at true.cz>
---
 fwtool.c | 13 ++++++++++---
 1 file changed, 10 insertions(+), 3 deletions(-)

diff --git a/fwtool.c b/fwtool.c
index 89e89514ad35..c059331ad231 100644
--- a/fwtool.c
+++ b/fwtool.c
@@ -213,7 +213,9 @@ add_data(const char *name)
 
 	if (ret) {
 		fflush(firmware_file);
-		ftruncate(fileno(firmware_file), file_len);
+		ret = ftruncate(fileno(firmware_file), file_len);
+		if (ret < 0)
+			msg("Error during ftruncate: %m\n");
 	}
 
 	return ret;
@@ -374,8 +376,13 @@ extract_data(const char *name)
 		}
 	}
 
-	if (!ret && truncate_file)
-		ftruncate(fileno(firmware_file), dbuf.file_len);
+	if (!ret && truncate_file) {
+		ret = ftruncate(fileno(firmware_file), dbuf.file_len);
+		if (ret < 0) {
+			msg("Error during ftruncate: %m\n");
+			goto out;
+		}
+	}
 
 	if (write_truncated) {
 		if (dbuf.prev)

_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel


More information about the openwrt-devel mailing list