[OpenWrt-Devel] [PATCH 4/5] target/generic: add ascii search option to mtd-mac-address helper

[André Valentin]

Hi Petr,

I got it from here:
lede/target/linux/ar71xx/files/arch/mips/ath79/nvram.c


Am 21.10.19 um 16:06 schrieb Petr Štetiar:
> André Valentin <avalentin at marcant.net> [2019-10-21 15:13:55]:
> 
>> Am 21.10.19 um 15:02 schrieb Petr Štetiar:
>>> André Valentin <avalentin at marcant.net> [2019-10-21 14:32:13]:
>>>
>>>> This improves the function of_get_mac_address_mtd...
>>>
>>> but on the other hand its also introducing something which would never be
>>> accepted upstream, for details see my other comment[1].
>>
>> I also saw that. I could move it into a separate "driver"?
> 
> It won't help, we certainly don't want to read complete flash partition into
> RAM just to search for some needle, your code is happy with first needle
> occurence (smeling hard to reproduce issues) so you should aim for fixed
> offset, so in the end it's Yousong's mtd-mac-address-ascii[1] what you're
> probably looking for.
> 
>> I also noticed the nvmem provider, but that is a bit to tricky for me.
> 
> Indeed, making something accepted upstream is tedious and time consuming
> process, but its usually worth this effort in the longterm and should be
> preferred.

In that case I will drop it. It's nice, but not really needed.

> 
>>>> Code has been taken from ar71xx.
>>>
>>> It makes me wonder from where exactly as I can't seem to find it.
> 
> so where is it originating from? :-)
> 
> 1. http://patchwork.ozlabs.org/patch/1112495/#2189030
> 
> -- ynezz
> 
Kind regards,

André


-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 4058 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://lists.infradead.org/pipermail/openwrt-devel/attachments/20191021/0213a2ef/attachment.p7s>
-------------- next part --------------
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel