[OpenWrt-Devel] [PATCH] uqmi: separate into libuqmi library and uqmi util itself

[John Crispin]

On 23/08/2019 15:57, Denis Kalashnikov wrote:
> It is needed to reuse qmi code, e.g. in a modem manager util
> which is useful on routers with several cell modems.
> 
> Signed-off-by: Denis Kalashnikov <denis281089 at gmail.com>
> 
Hi,
patch looks looks but  ....

> +Index: uqmi-2019-06-27-1965c713/dev.c
> +===================================================================
> +--- uqmi-2019-06-27-1965c713.orig/dev.c
> ++++ uqmi-2019-06-27-1965c713/dev.c
> +@@ -353,8 +353,6 @@ int qmi_device_open(struct qmi_dev *qmi,
> + 	struct ustream *us = &qmi->sf.stream;
> + 	int fd;
> +
> +-	uloop_init();
> +-

this would break uqmi cli
	John

> + 	fd = open(path, O_RDWR | O_EXCL | O_NONBLOCK | O_NOCTTY);
> + 	if (fd < 0)
> + 		return -1;
> 


_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel