[OpenWrt-Devel] [PATCH] ath79: add AR934x NAND Flash Controller driver

[Michal Cieslakiewicz]

On Mon, 14 Oct 2019 12:57:29 +0200
David Bauer <mail at david-bauer.net> wrote:

> Hello Michal
> 
> On 10/14/19 12:22 AM, Michal Cieslakiewicz wrote:
> > Hello David,
> > 
> > Yes, please update my commit.
> > 
> > Thank you for your feedback, review and tests. Indeed I (wrongly)
> > assumed minimalistic approach and delegated ar71xx reset procedure
> > to a simple DT property. I have only WNDR4300 to test the driver -
> > this router interestingly has no problems whatsoever (I've booted
> > it tens of times). ar934x-nand is my first DT driver port ever, and
> > I thanks to your patch now I know more about implementing reset
> > features :-)   
> 
> No Problem (and thanks for taking care of that). I've started work on
> the NAND driver some months ago, but quickly lost interested as more
> fun stuff was around. Glad to see this coming true.
> 
> The ar71xx implementation also triggered resets for the ethernet
> switch analog. I'm a bit lost here grasping the correlation. I will
> try to get my hands on GPL source from the Atheros implementation,
> seeing I can make out the reason for this reset.
> 
> Best wishes
> David
> 

Hello David,

Yes, this 'analog switch reset' puzzles me also, there are no clues how
it affects NAND chip in official AR9344 datasheet. Also in Netgear's
u-boot sources there is a reset sequence in ath_nand_hw_init() function
(board/ar7240/common/ath_nand.c file), but it does not even touch
ethernet switch.
For now I've found a place for it in WNDR4300 dts file in
'&builtin_switch' section where it's added to generic ethernet switch
reset. No problems so far on my WNDR4300, neither with NAND nor with
network.

Best regards
Michal

_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel