[OpenWrt-Devel] [PATCH v3] ramips: add support for JS76x8 series DEV boards

[Adrian Schmutzler]

Hi again,

> @@ -543,7 +546,10 @@ ramips_setup_macs()
>  	hilink,hlk-rm04|\
>  	nexaira,bc2|\
>  	petatel,psr-680w|\
> -	skyline,sl-r7205)
> +	skyline,sl-r7205|\
> +	zhuotk,js76x8-16m|\
> +	zhuotk,js76x8-32m|\
> +	zhuotk,js76x8-8m)
>  		lan_mac=$(macaddr_setbit_la "$(cat /sys/class/net/eth0/address)")
>  		wan_mac=$(macaddr_add "$lan_mac" 1)
>  		;;

for a long time already I'm looking for someone to explain to me why this is used. Now you volunteered for that job ;-)

You set the ethernet address in DTS, to a real MAC address, determining eth0.
Now you set lan_mac to a local address, having all LAN ports use them.
And you set wan_mac to a another address, calculated from lan_mac, so also with local bit set, and have WAN ports use that.

So, all your ports will have local addresses, while the real non-local MAC address isn't used at all.

Is there a reason for that I just don't see or is this a mistake?

Despite, I assume this means that there is no WAN MAC address in flash, e.g. at 0x2e?

Best

Adrian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: openpgp-digital-signature.asc
Type: application/pgp-signature
Size: 834 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/openwrt-devel/attachments/20191010/8da59b81/attachment.sig>
-------------- next part --------------
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel