[OpenWrt-Devel] RE：RE: [PATCH v4 1/3] ramips: add support for JS7628 development board

[Adrian Schmutzler]

Ah, sorry, too late. Didn't realize you already sent a patch as you started with v1 again ...

> -----Original Message-----
> From: openwrt-devel [mailto:openwrt-devel-bounces at lists.openwrt.org] On Behalf Of Adrian Schmutzler
> Sent: Mittwoch, 9. Oktober 2019 13:48
> To: '且听风吟' <wurobinson at qq.com>
> Cc: 'openwrt-devel' <openwrt-devel at lists.openwrt.org>
> Subject: Re: [OpenWrt-Devel] RE：RE: [PATCH v4 1/3] ramips: add support for JS7628 development board
> 
> Hi,
> 
> before you resend you patches, two other comments:
> 
> 1. When we introduced DEVICE_VARIANT, we typically removed the "flash" reference formerly present in the DEVICE_TITLE.
> 
> So you might update your DEVICE_VARIANT entries for consistency, e.g.
> 
> DEVICE_VARIANT := 32M flash
> 
> to
> 
> DEVICE_VARIANT := 32M
> 
> 2. Currently, you set up wan MAC address to eth0 + 1 with the default case in 02_network (line 731).
> 
> Do the boards have a wan MAC address on flash (0x2e or somewhere else)? If yes, please add it to the ramips_setup_macs() section
> (starting line 516) explicitly.
> 
> Same would be necessary if the wan address is _not_ different from the lan/eth0 address. In this case add your boards to the "empty
> case" starting in line 584.
> 
> As those are development boards, they most probably won't have a label with a MAC address on them?
> 
> Despite, I do not have commit access, so expect comments from other people or further waiting.
> 
> Best
> 
> Adrian Schmutzler
-------------- next part --------------
A non-text attachment was scrubbed...
Name: openpgp-digital-signature.asc
Type: application/pgp-signature
Size: 834 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/openwrt-devel/attachments/20191009/b46272ec/attachment.sig>
-------------- next part --------------
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel