[OpenWrt-Devel] [PATCH 1/4] kernel: remove obsolete phylink/SFP patches
Jonas Gorski
jonas.gorski at gmail.com
Mon Nov 25 12:10:18 EST 2019
On Mon, 25 Nov 2019 at 17:49, Russell King <linux at armlinux.org.uk> wrote:
>
> Remove the old phylink/SFP patches from the OpenWRT build; these will
> be updated with a new set in subsequent.
>
> 450-reprobe_sfp_phy is also removed for several reasons:
> 1) it is not in mainline.
> 2) it breaks copper modules that do not have a PHY.
> 3) it makes backporting the current patch set harder.
>
> Discussion is ongoing with the patch author for a mainline Linux kernel
> patch for this.
You can also just put me in Cc ;P
Is using this patchset enough for the tests you asked, or are there
some additional changes in your branch?
Regards
Jonas
-- * this time, that's fine too.
> -- */
> -- sfp_sm_next(sfp, SFP_S_INIT, T_INIT_JIFFIES);
> -- sfp->sm_retries = 5;
> -+ sfp_module_tx_enable(sfp);
> -
> - /* Setting the serdes link mode is guesswork: there's no
> - * field in the EEPROM which indicates what mode should
> -@@ -1485,7 +1482,22 @@ static void sfp_sm_mod_init(struct sfp *
> - if (sfp->id.base.e1000_base_t ||
> - sfp->id.base.e100_base_lx ||
> - sfp->id.base.e100_base_fx)
> -- sfp_sm_probe_phy(sfp);
> -+ ret = sfp_sm_probe_phy(sfp);
> -+
> -+ if (!ret) {
> -+ /* Wait t_init before indicating that the link is up, provided
> -+ * the current state indicates no TX_FAULT. If TX_FAULT clears
> -+ * this time, that's fine too.
> -+ */
> -+ sfp_sm_next(sfp, SFP_S_INIT, T_INIT_JIFFIES);
> -+ sfp->sm_retries = 5;
> -+ return;
> -+ }
> -+
> -+ if (ret == -EAGAIN)
> -+ sfp_sm_set_timer(sfp, T_PROBE_RETRY);
> -+ else
> -+ sfp_sm_next(sfp, SFP_S_TX_DISABLE, 0);
> - }
> -
> - static int sfp_sm_mod_hpower(struct sfp *sfp)
> --
> 2.20.1
>
>
> _______________________________________________
> openwrt-devel mailing list
> openwrt-devel at lists.openwrt.org
> https://lists.openwrt.org/mailman/listinfo/openwrt-devel
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel
More information about the openwrt-devel
mailing list