[OpenWrt-Devel] [PATCH] treewide: remove dts-v1 identifier from DTSI files

[Adrian Schmutzler]

Hi,

> -----Original Message-----
> From: openwrt-devel [mailto:openwrt-devel-bounces at lists.openwrt.org] On
> Behalf Of mans0n
> Sent: Montag, 25. November 2019 17:33
> To: openwrt-devel at lists.openwrt.org
> Cc: Adrian Schmutzler <freifunk at adrianschmutzler.de>
> Subject: Re: [OpenWrt-Devel] [PATCH] treewide: remove dts-v1 identifier from
> DTSI files
> 
> Hi Adrian,
> 
> I already read your previous mail two weeks ago, but then I was not very
> familiar with these mailing list stuff (still I am). Sorry for the late
> reply.
> 
> On 19. 11. 25. 6:53 AM, Adrian Schmutzler wrote:
>  > The "/dts-v1/;" identifier is supposed to be put once at the beginning
>  > of a device tree file. Thus, it makes no sense to provide it a second
>  > time in to-be-included DTSI files.
> 
> Three months ago I was totally on your side, but while preparing for my
> A3 PR, I noticed two things:
> 
> 1. The kernel also has (quite many) DTSI files with "/dts-v1/;". I'm not
> sure if this is intentional or also a mistake.
> 2. AFAIK documentation does not prohibit DTSI files with "/dts-v1/;".
> And DTSI files in OpenWrt follow v1 syntax (and not v0 nor non-existent
> v2), so I thought it would be better to clarify that. I'm not sure if
> it's okay if the version of DTS file is different from that of DTSI
> file, though.

Since I received no feedback here, I went to the devicetree-spec list.

https://www.spinics.net/lists/devicetree-spec/msg00893.html

Based on that, having dts-v1 in the dtsi is discouraged when it's in the dts already (though not restricted by the parser ATM).

It would make sense if it was _only_ in the dtsi, and the dtsi being first include in the dts.

This is what's currently done with qcom-ipq8064.dtsi in ipq806x, although I suspect by accident.
I actually think about removing this one from the patch, or moving the definition to the dtses instead.

For ath79/ramips however, all DTS files feature the dts-v1, so the proper (though pedantic) way to me seems to remove the entries in the dtsi there.

Thanks for your thoughts anyway.

Best

Adrian



> 
> That's why I included "/dts-v1/;" in mt7628an_iptime.dtsi. I don't have
> any objection to this patch, I just wanted to leave a comment on this issue.
> 
> Thanks.
> 
> _______________________________________________
> openwrt-devel mailing list
> openwrt-devel at lists.openwrt.org
> https://lists.openwrt.org/mailman/listinfo/openwrt-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: openpgp-digital-signature.asc
Type: application/pgp-signature
Size: 834 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/openwrt-devel/attachments/20191125/c12c0bc3/attachment.sig>
-------------- next part --------------
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel