[OpenWrt-Devel] [PATCH v4] ramips: add support for JS76x8 series DEV boards

[Adrian Schmutzler]

Hi,

there has been a split of the board.d files in ramips target towards the subtargets, so you would have to rebase onto that. (Put your definitions into mt76x8/base-files/etc/board.d/0x... instead of base-files/etc/board.d/0x...).

Despite, two additional comments below.

> diff --git a/target/linux/ramips/dts/mt7628an_zhuotk_js76x8-16m.dts
> b/target/linux/ramips/dts/mt7628an_zhuotk_js76x8-16m.dts
> new file mode 100644
> index 0000000..7123e63
> --- /dev/null
> +++ b/target/linux/ramips/dts/mt7628an_zhuotk_js76x8-16m.dts
> @@ -0,0 +1,60 @@
> +/dts-v1/;
> +
> +#include "mt7628an_zhuotk_js76x8.dtsi"
> +
> +/ {
> +	compatible = "zhuotk,js76x8-16m", "zhuotk,js76x8",
> "mediatek,mt7628an-soc";
> +	model = "ZhuoTK JS76x8 (16M)";
> +};
> +
> +&spi0 {
> +	status = "okay";

The only difference between your DTS files here is the size of the firmware partition. Thus, you should move the entire spi0 node to the DTSI. There you would add a label to the partition at 50000 node:

	firmware: partition at 50000 {

Then, remove the reg entry for the firmware partition in the DTSI and just put that one in the DTS files. With that change, DTS file would only contain compatible/model and firmware partition size:

&firmware {
	reg = <0x50000 0x7b0000>;
};

Obviously, just use the correct size for the according DTS files. 

[...]
> +
> +	gpio-leds {

This should be named "leds".

Best

Adrian 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: openpgp-digital-signature.asc
Type: application/pgp-signature
Size: 834 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/openwrt-devel/attachments/20191104/034d7529/attachment.sig>
-------------- next part --------------
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel