[OpenWrt-Devel] [PATCH] ath79: Add support for ZBT-WD323

[Kristian Evensen]

Hi Petr,

Thanks for your comments.

On Fri, May 31, 2019 at 9:57 AM Petr Štetiar <ynezz at true.cz> wrote:
> > +zbtlink,zbt-wd323)
> > +     ucidef_set_led_wlan "wlan" "WLAN" "$boardname:green:wifi" "phy0tpt"
> > +     ;;
> >  esac
>
> Please add this trigger to the DTS.

Will do.

> > +#include "ar9344.dtsi"
> > +     compatible = "zbtlink,zbt-wd323", "qca,ar9334";
>
> Is it really ar9334 ?

Thanks for spotting my typo, too many 3s and 4s :)

> > +     aliases {
> > +             serial0 = &uart;
> > +     };
>
> Why do you need this alias? Does it work without it? ar9344 has ns16550a UART
> which doesn't need this alias.

Probably not and this was just a c&p from the dts I started with. I
will try without.

> > +     keys {
> > +             compatible = "gpio-keys-polled";
>
> Does it work for you with "gpio-keys" compatible? It's interrupt driven, so
> should be preferred.

Will try.

BR,
Kristian

_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel