[OpenWrt-Devel] [OpenWrt-Devel, 3/7] at91: Generate sdcard images for at91sam9x5ek boards.

[Hauke Mehrtens]

On 5/28/19 7:21 PM, Sandeep Sheriker M wrote:
> From: Sandeep Sheriker Mallikarjun <sandeepsheriker.mallikarjun at microchip.com>
> 
> Signed-off-by: Sandeep Sheriker Mallikarjun <sandeepsheriker.mallikarjun at microchip.com>
> Signed-off-by: Sandeep Sheriker M <sandeep.sheriker at microchip.com>
> ---
>  target/linux/at91/image/Makefile | 8 +++++++-
>  target/linux/at91/image/sam9x.mk | 5 +++++
>  2 files changed, 12 insertions(+), 1 deletion(-)
> 
> diff --git a/target/linux/at91/image/Makefile b/target/linux/at91/image/Makefile
> index e4c17e3..5b1433c 100644
> --- a/target/linux/at91/image/Makefile
> +++ b/target/linux/at91/image/Makefile
> @@ -51,13 +51,19 @@ define Build/at91-sdcard
>       mcopy -i $@.boot $(DTS_DIR)/$(dts).dtb \
>          ::$(dts).dtb)
>  
> +  $(if $(findstring sama5,$(DEVICE_NAME)) , \
>    mcopy -i $@.boot \
>      $(BIN_DIR)/u-boot-$(DEVICE_NAME:at91-%=%)_mmc/u-boot.bin \
>      ::u-boot.bin
>  
>    mcopy -i $@.boot \
>      $(BIN_DIR)/at91bootstrap-$(DEVICE_NAME:at91-%=%)sd*/at91bootstrap.bin \
> -    ::BOOT.bin
> +    ::BOOT.bin ,
> +
> +  mcopy -i $@.boot $(BIN_DIR)/u-boot-*_mmc/u-boot.bin ::u-boot.bin
> +
> +  mcopy -i $@.boot \
> +    $(BIN_DIR)/at91bootstrap-*sd*/at91bootstrap.bin ::BOOT.bin)
>  

Wouldn't it be more maintainable to split the at91-sdcard build part
into multiple parts?

Is it save to use at91bootstrap-*sd*/ ? are you sure it will take the
correct file?


>    ./gen_at91_sdcard_img.sh \
>        $@.img \

_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel