[OpenWrt-Devel] [PATCH] zlib: Use relative paths in pkg-config metadata file

[Jeffery To]

On Fri, May 3, 2019 at 5:32 PM Petr Štetiar <ynezz at true.cz> wrote:

> Jeffery To <jeffery.to at gmail.com> [2019-05-03 00:47:06]:
>
> > The default zlib.pc file generated by cmake contains absolute paths.
> > This patches the file to use relative paths (relative to ${prefix} and
> > ${exec_prefix}).
>
> I can see that from the diff already, but I miss the information, why do
> you
> need this change. Could this perhaps be upstreamed first as well?
>
> -- ynezz
>

The buildroot pkg-config (in staging_dir/host/bin) overrides the prefix and
exec_prefix variables in *.pc files, to supply the correct (buildroot)
paths for callers. If other variables are not defined relative to prefix
and exec_prefix, then the returned values will be incorrect.

A similar change was merged for xz[1] in the packages repo.

I'm not sure upstream will want this change, since what is there currently
isn't "wrong"; it only affects our cross-compilation.


1. https://github.com/openwrt/packages/pull/8880
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.infradead.org/pipermail/openwrt-devel/attachments/20190515/e8857691/attachment.htm>
-------------- next part --------------
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel