[OpenWrt-Devel] [PATCH] zynq: add manufactured to device title

[Petr Štetiar]

Luis Araneda <luaraneda at gmail.com> [2019-04-28 11:17:14]:

Hi,

> Make the device's title consistent by adding the manufacturer to their
> title, as the other boards on the target.  Additionally, this creates a
> sorted by manufacturer board list on menuconfig

your changes, doesn't correspond with the commit description, see bellow.

> diff --git a/target/linux/zynq/image/Makefile b/target/linux/zynq/image/Makefile
> index d8a882313b..380b07bb82 100644
> --- a/target/linux/zynq/image/Makefile
> +++ b/target/linux/zynq/image/Makefile
> @@ -58,7 +58,7 @@ TARGET_DEVICES += avnet_zynq-zed
>  
>  define Device/digilent_zynq-zybo
>  	$(call Device/FitImageGzip)
> -	DEVICE_TITLE := ZYBO Development Board
> +	DEVICE_TITLE := Digilent Zybo board

why are you removing the development part? I think, that it's useful
information so it shouldn't be removed if you don't have a good reason for
this. Putting appart the fact, that it's marked as trainer board on the
vendor's site[1].

>  define Device/xlnx_zynq-zc702
>  	$(call Device/FitImageGzip)
> -	DEVICE_TITLE := ZC702 Development Board
> +	DEVICE_TITLE := Xilinx ZC702 board

ditto, putting apart the fact, that it's marked as evaluation kit on the
vendor's site[2].

1. https://store.digilentinc.com/zybo-zynq-7000-arm-fpga-soc-trainer-board
2. https://www.xilinx.com/products/boards-and-kits/ek-z7-zc702-g.html

-- ynezz

_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel