[OpenWrt-Devel] [RFC] DTS vs UCI based LED triggers [Was: [PATCH] ramips: add Netgear EX6150]

[Petr Štetiar]

Petr Štetiar <ynezz at true.cz> [2019-03-25 16:38:10]:

> > +netgear,ex6150)
> > +	ucidef_set_led_wlan "wlan2g" "WiFi 2.4GHz" "$boardname:green:router" "phy1tpt"
> > +	ucidef_set_led_wlan "wlan5g" "WiFi 5GHz" "$boardname:green:client" "phy0tpt"
> > +	;;
> 
> I would like to merge this patch[1], but I've moved this LED UCI settings to
> DTS under LED nodes, where I believe it belongs. While confirming this changes
> with David on IRC, I've been told, that he has done so on purpose as it might
> be prefered on ramips platform. So what are the preferences? Thanks!

Ok, so I read it as nobody has strong objections against it, so I'm inclined
to consider it as a green light and I'm going to build test it over night and
push it as it is in my staging tree tomorrow.

-- ynezz

_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel