[OpenWrt-Devel] [PATCH 1/7] tegra: add new target

[Tomasz Maciej Nowak]

Hi Hauke,

W dniu 25.03.2019 o 23:39, Hauke Mehrtens pisze:
> Hi Tomasz,
> 
> Soke small comments, this looks mostly ok.
> 
[snip]
>> +# CONFIG_ARM_LPAE is not set
> 
> Is LPAE not supported by your SoC? This is needed for KVM support, but
> not all CPUs support this.
> 

Not really sure, seems it should be enabled for all ARM v7, it was disabled in tegra_defconfig. Enabling this shouldn't do any harm, will test this.

[snip]
>> +CONFIG_EXT2_FS=y
> 
> We normally use the ext4 driver to handle ext2.

Ack, will change to EXT4_USE_FOR_EXT2.

> 
>> +CONFIG_EXT4_FS=y
>> +CONFIG_EXT4_FS_POSIX_ACL=y
> 
> Do you need ACL support?
> 

No, will remove it.

[snip]
>> +# CONFIG_JFFS2_FS is not set
> 
> This would be needed for overlay filesystems.
> 

I was thinking that if F2FS is enabled, it's used as overlay, will enable it.

>> +CONFIG_KALLSYMS=y
> 
> CONFIG_KALLSYMS should not be activated by default.
> 

Ack, will remove it.

>> +CONFIG_LIBFDT=y
>> +CONFIG_LOCK_SPIN_ON_OWNER=y
>> +CONFIG_LZ4HC_COMPRESS=y
>> +CONFIG_LZ4_COMPRESS=y
>> +CONFIG_LZ4_DECOMPRESS=y
>> +CONFIG_LZO_COMPRESS=y
>> +CONFIG_LZO_DECOMPRESS=y
>> +CONFIG_MANDATORY_FILE_LOCKING=y
> 
> Why do you need CONFIG_MANDATORY_FILE_LOCKING?
> 

It's not needed, this is remnant of basing this config on tegra_defconfig and I didn't delve when i saw MANDATORY, will remove it.

Thank You for review, I will send v3 ASAP.

Regards

-- 
TMN

_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel