[OpenWrt-Devel] [PATCH] ath79: add suport for EnGenius EPG5000

[Tomasz Maciej Nowak]

W dniu 06.03.2019 o 21:03, Tomasz Maciej Nowak pisze:
> Hi,
> 
> W dniu 04.03.2019 o 21:54, Petr Štetiar pisze:
>> Tomasz Maciej Nowak <tomek_n at o2.pl> [2019-03-04 15:18:53]:
>>
>>> +		wan {
>>> +			label = "epg5000:blue:wan";
>>> +			gpios = <&gpio 22 GPIO_ACTIVE_LOW>;
>>> +		};
>>
>> this LED is marked in ar71xx as `epg5000:amber:wps` any reason for this change?
> 
> There is no second WPS LED on the device, check the manual https://www.engeniustech.com/resources/EPG5000-user_manual.pdf on page 9. Also the color of it is blue instead of amber. The whole mach file in ar71xx seems to be copy pasta from similar ESR1750 with only name of the device changed throughout the file, and errors replicated. The ESR1750 also doesn't have two WPS LEDs, but I don't know which color it is since I don't own such device.

I was wrong, there is another WPS LED on the PCB, the mach file from ar71xx has the correct description. I skimmed to fast with the testing and assumed only visible LEDs on the case are valid, therefore assigned them to labels present on the case, which was wrong. Sorry for the confusion. Fix sent.

Regards

-- 
TMN

_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel