[OpenWrt-Devel] [PATCH] ath79: add suport for EnGenius EPG5000

[Tomasz Maciej Nowak]

Hi,

W dniu 04.03.2019 o 21:54, Petr Štetiar pisze:
> Tomasz Maciej Nowak <tomek_n at o2.pl> [2019-03-04 15:18:53]:
> 
> Hi,
> 
>> When doing upgrade from OpenWrt ar71xx image, it is recomended to not keep the
>> old configuration.
> 
> why is that?

The sysfs path to 2.4 wifi has changed, so after the upgrade it won't be enabled. Better tell the users that they need to create new configuration, than explaining that the upgrade didn't break wifi.

> 
>> +		wan {
>> +			label = "epg5000:blue:wan";
>> +			gpios = <&gpio 22 GPIO_ACTIVE_LOW>;
>> +		};
> 
> this LED is marked in ar71xx as `epg5000:amber:wps` any reason for this change?

There is no second WPS LED on the device, check the manual https://www.engeniustech.com/resources/EPG5000-user_manual.pdf on page 9. Also the color of it is blue instead of amber. The whole mach file in ar71xx seems to be copy pasta from similar ESR1750 with only name of the device changed throughout the file, and errors replicated. The ESR1750 also doesn't have two WPS LEDs, but I don't know which color it is since I don't own such device.

> 
>> +		wlan2g {
>> +			label = "epg5000:blue:wlan2g";
>> +			gpios = <&gpio 13 GPIO_ACTIVE_LOW>;
>> +			linux,default-trigger = "phy1tpt";
>> +		};
> 
> In ar71xx it's named as `epg5000:blue:wlan-2g`, so to keep the upgrade process
> to ath79 seamless it would be good idea to use the same name.
> 

Wanted to change it to the same name as most devices in this targe, but don't have strong feeling about it so if any of Committers would request the change, I will adapt.

>> +
>> +		wlan5g {
>> +			label = "epg5000:blue:wlan5g";
>> +			gpios = <&gpio 23 GPIO_ACTIVE_LOW>;
>> +			linux,default-trigger = "phy0tpt";
>> +		};
> 
> In ar71xx it's named as `epg5000:blue:wlan-5g`.
> 
> -- ynezz
> 

Regards

-- 
TMN

_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel