[OpenWrt-Devel] [PATCH] ramips: mt7621: Add new device AsiaRF AP7621-001

[Christian Lamparter]

On Tuesday, June 25, 2019 10:34:47 AM CEST Daniel Danzberger wrote:
> 
> On 6/24/19 10:17 PM, Christian Lamparter wrote:
> >> diff --git a/target/linux/ramips/dts/AP7621-001.dts b/target/linux/ramips/dts/AP7621-001.dts
> >> new file mode 100644
> >> index 0000000000..daab06ec90
> >> --- /dev/null
> >> +++ b/target/linux/ramips/dts/AP7621-001.dts
> >> @@ -0,0 +1,127 @@
> >> +// SPDX-License-Identifier: GPL-2.0-or-later OR MIT
> >> +
> >> +/dts-v1/;
> >> +#include "mt7621.dtsi"
> >> +
> >> +#include <dt-bindings/gpio/gpio.h>
> >> +#include <dt-bindings/input/input.h>
> >> +
> >> +/ {
> >> +	compatible = "asiarf,ap7621-001", "mediatek,mt7621-soc";
> >> +	model = "AP7621-001";
> > 
> > Oh boy, this is tricky.
> > 
> > <https://github.com/devicetree-org/devicetree-specification/blob/4b1dac80eaca45b4babf5299452a951008a5d864/source/devicenodes.rst>
> > 'The recommended format ' (for the root node!) ' is "manufacturer,model-number".'
> > 
> > BUT. Thing is, this string here gets printed on the LuCI system
> > page and from past experience "Manufacturer Model" works best.
> >
> I am not sure if using a blank instead of ',' is a good idea, because of
> sysupgrade and the device tree board detection.
> All other DTS files use ',' in DTS and '_' in their Makefile.
> 
> Are you sure about this one ?
> 
Hm, I think this is a misunderstanding?
The compatible "asiarf,ap7621-001" is fine. But the "model" property could use
the manufacturer.

(Note: The sysupgrade codes uses the first compatible string, not the model)

Cheers,
Christian



_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel