[OpenWrt-Devel] [PATCH 1/2] gpio-button-hotplug: support interrupt properties

[Petr Štetiar]

Petr Štetiar <ynezz at true.cz> [2019-06-02 14:06:30]:

Hi,

> > > On Thursday, May 30, 2019 12:00:27 PM CEST Petr Štetiar wrote:
> > > > 
> > > > I've just checked this on ath79 (archer-c7-v5) and on ramips/mt7620
> > > > (bdcom,wap2100-sk) with WPS buttons.
> > > >
> > > > Acked-by: Petr Štetiar <ynezz at true.cz>
> > > 
> > > Can you tell me what you tested? Was it the software debounce?
> > > Because this should be the only bit that will affect the ath79
> > > platform I think (since it already has support for interrupts
> > > through the gpio controller).
> > 
> > it was just FYI, that I've checked it (run tested) and didn't noticed any side
> > effects, possible regressions.  I've simply added this patch on top of fix for
> > FS#1965 and run tested it together.
> 
> apparently I didn't tested it well, someone has reported following on the IRC:
> 
>  04:39:23 < kyli> After commit afc056d7dc, the button stopped working properly
>  on my ramips/mt7620 target. The first press of a button after reboot will get
>  a LARGE SEEN, and it will be interpreted as a long press. So even a short
>  press on reset will trigger FACTORY RESET.... Is anyone experiencing the same
>  problem?

so I can confirm this behaviour, but it's not caused by your patch as it
doesn't work even with your patch reverted. There's simply unhandled corner
case, where the seen is wrong if the button is pressed for the first time and
I'll shortly send a patch which should fix this.

-- ynezz

_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel